Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix arg passing to getcwd syscall #292

Merged
merged 1 commit into from
Mar 26, 2019
Merged

fix arg passing to getcwd syscall #292

merged 1 commit into from
Mar 26, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

No description provided.

@MarkMcCaskey MarkMcCaskey added the bug Something isn't working label Mar 26, 2019
@MarkMcCaskey MarkMcCaskey requested a review from xmclark March 26, 2019 21:38
xmclark
xmclark approved these changes Mar 26, 2019
View reviewed changes
Copy link
Contributor

@xmclark xmclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try out lua and nginx to see if it still works, but looks great!

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Mar 26, 2019
@bors
Merge #292
3a5cc86 
292: fix arg passing to getcwd syscall r=MarkMcCaskey a=MarkMcCaskey



Co-authored-by: Mark McCaskey <mark@wasmer.io>
@MarkMcCaskey MarkMcCaskey removed the bug Something isn't working label Mar 26, 2019
@MarkMcCaskey
Copy link
Contributor Author

I can't add labels right now... Looks like a Github bug?

@bors
Copy link
Contributor

bors bot commented Mar 26, 2019

Timed out

@MarkMcCaskey
Copy link
Contributor Author

bors retry

bors bot added a commit that referenced this pull request Mar 26, 2019
@bors
Merge #292
02e6898 
292: fix arg passing to getcwd syscall r=MarkMcCaskey a=MarkMcCaskey



Co-authored-by: Mark McCaskey <mark@wasmer.io>
@bors
Copy link
Contributor

bors bot commented Mar 26, 2019

Timed out

@MarkMcCaskey
Copy link
Contributor Author

bors retry

bors bot added a commit that referenced this pull request Mar 26, 2019
@bors
Merge #292
cb35057 
292: fix arg passing to getcwd syscall r=MarkMcCaskey a=MarkMcCaskey



Co-authored-by: Mark McCaskey <mark@wasmer.io>
@bors
Copy link
Contributor

bors bot commented Mar 26, 2019

Build succeeded

@bors bors bot merged commit 49db149 into master Mar 26, 2019
@bors bors bot deleted the fix/arg-passing-to-getcwd-syscall branch March 26, 2019 23:26
@MarkMcCaskey MarkMcCaskey added bug Something isn't working 📦 lib-emscripten About wasmer-emscripten labels Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmclark xmclark xmclark approved these changes

Assignees
No one assigned
Labels
bug Something isn't working 📦 lib-emscripten About wasmer-emscripten
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkMcCaskey @xmclark