generate null funcs #295
Merged
generate null funcs #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
bjfish
reviewed
Mar 27, 2019
lib/runtime-core/src/macros.rs
Outdated
|
|
||
| #[macro_export] | ||
| #[doc(hidden)] | ||
| macro_rules! ecapseman { |
syrusakbary
reviewed
Mar 27, 2019
lib/emscripten/src/lib.rs
Outdated
| import_object | ||
| } | ||
|
|
||
| pub fn nullfunc_x(ctx: &mut Ctx, _x: u32) { |
There was a problem hiding this comment.
Should be just nullfunc? (without an x)
pub fn nullfunc(ctx: &mut Ctx) {
...
}
syrusakbary
approved these changes
Mar 27, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 27, 2019
295: generate null funcs r=syrusakbary a=xmclark This PR automates adding the `nullfunc` imports. A new macro is added to help working with namespaces. All functions in the env namespace that start with `nullFunc_` will be added to the import object. This is easy because *all* null funcs have the same expected signature. Co-authored-by: Mackenzie Clark <mackenzie.a.z.c@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR automates adding the
nullfuncimports. A new macro is added to help working with namespaces. All functions in the env namespace that start withnullFunc_will be added to the import object. This is easy because all null funcs have the same expected signature.