Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "run --invoke [function]" to behave the same as "run" #2997

Merged
merged 4 commits into from
Jul 22, 2022
Merged

Fix "run --invoke [function]" to behave the same as "run" #2997

merged 4 commits into from
Jul 22, 2022
+83 −3

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Jul 1, 2022 •
edited
Loading

Prior to this change, wasmer run --function _start and wasmer run would behave
differently because wasmer run uses the WASI environment but --invoke did not.

Closes #2978.

Review

  • Add a short description of the change to the CHANGELOG.md file

Sorry, something went wrong.

@fschutt fschutt requested a review from syrusakbary as a code owner July 1, 2022 12:48
@fschutt fschutt marked this pull request as draft July 1, 2022 12:48
@fschutt fschutt self-assigned this Jul 4, 2022
@fschutt fschutt marked this pull request as ready for review July 4, 2022 11:29
epilys
epilys approved these changes Jul 4, 2022
View reviewed changes
tests/integration/cli/Cargo.toml
Comment on lines +10 to +12
[dev-dependencies]
rand = "0.8.5"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tempfile is useful for this workflow. (Don't rewrite your PR for this minor thing, it's just a suggestion for future tests)

@syrusakbary syrusakbary mentioned this pull request Jul 5, 2022
Closed
@fschutt fschutt force-pushed the test-wasi-nomain branch from d4af519 to f0a26b8 Compare July 12, 2022 08:22
@syrusakbary
Copy link
Member

I think we should merge #2892 first

@epilys
Copy link
Contributor

epilys commented Jul 21, 2022

Please rebase, not merge. Merge commits should not exist in PRs.

@fschutt fschutt force-pushed the test-wasi-nomain branch from 9cb18bf to 8ec204f Compare July 22, 2022 14:48
fschutt added 4 commits July 22, 2022 16:52
@fschutt
Add unit test to test that the WASI env isn't accidentally disabled
9213d8b
@fschutt
Fix --invoke [function] to behave the same as "run" (closes #2978)
3435945
@fschutt
Add CHANGELOG entry

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8394cc1
@fschutt
cargo fmt
35d880d
@fschutt fschutt force-pushed the test-wasi-nomain branch from ad4545a to 35d880d Compare July 22, 2022 14:52
@fschutt
Copy link
Contributor Author

fschutt commented Jul 22, 2022

@syrusakbary can be reviewed + merged now

@syrusakbary syrusakbary merged commit ea12ec0 into master Jul 22, 2022
@bors bors bot deleted the test-wasi-nomain branch July 22, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary

@epilys epilys

Assignees

@fschutt fschutt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using WASI from wasmer cli
3 participants
@fschutt @syrusakbary @epilys