Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get PHP kind of working #326

Merged
merged 5 commits into from
Apr 4, 2019
Merged

get PHP kind of working #326

merged 5 commits into from
Apr 4, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

No description provided.

@MarkMcCaskey MarkMcCaskey added the 📦 lib-emscripten About wasmer-emscripten label Apr 4, 2019
@MarkMcCaskey MarkMcCaskey requested a review from xmclark April 4, 2019 21:14
Copy link
Contributor

@xmclark xmclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it kind of works

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Apr 4, 2019
326: get PHP kind of working r=MarkMcCaskey a=MarkMcCaskey



Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Mackenzie Clark <mackenzie.a.z.c@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 4, 2019

@bors bors bot merged commit b6492c5 into master Apr 4, 2019
@bors bors bot deleted the feature/get-php-kind-of-working branch April 4, 2019 23:00
bors bot added a commit that referenced this pull request Apr 5, 2019
328: fix master; add some emscripten calls r=MarkMcCaskey a=MarkMcCaskey

notified by #327 ;
that program when compiled now outputs 
`"RuntimeError: WebAssembly trap occured during runtime: memory out-of-bounds access"` ;

which may have been broken by #326 

Co-authored-by: Mark McCaskey <mark@wasmer.io>
bors bot added a commit that referenced this pull request Apr 5, 2019
328: fix master; add some emscripten calls r=xmclark a=MarkMcCaskey

notified by #327 ;
that program when compiled now outputs 
`"RuntimeError: WebAssembly trap occured during runtime: memory out-of-bounds access"` ;

which may have been broken by #326 

Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Mackenzie Clark <mackenzie.a.z.c@gmail.com>
bors bot added a commit that referenced this pull request Apr 5, 2019
328: fix master; add some emscripten calls r=MarkMcCaskey a=MarkMcCaskey

notified by #327 ;
that program when compiled now outputs 
`"RuntimeError: WebAssembly trap occured during runtime: memory out-of-bounds access"` ;

which may have been broken by #326 

Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Mackenzie Clark <mackenzie.a.z.c@gmail.com>
bors bot added a commit that referenced this pull request Apr 5, 2019
328: fix master; add some emscripten calls r=MarkMcCaskey a=MarkMcCaskey

notified by #327 ;
that program when compiled now outputs 
`"RuntimeError: WebAssembly trap occured during runtime: memory out-of-bounds access"` ;

which may have been broken by #326 

resolves #327

Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Mackenzie Clark <mackenzie.a.z.c@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 lib-emscripten About wasmer-emscripten
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants