Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UserTrapper trait #366

Merged
merged 5 commits into from
Apr 18, 2019
Merged

Remove UserTrapper trait #366

merged 5 commits into from
Apr 18, 2019

Conversation

lachlansneff
Copy link
Contributor

This removes the UserTrapper trait and the thread_local EARLY_TRAPPER variable.

Fixes bug reported in #365.

@lachlansneff
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Apr 18, 2019
@bors
Try #366:
5cb673c
@lachlansneff lachlansneff mentioned this pull request Apr 18, 2019
Closed
@lachlansneff lachlansneff added bug Something isn't working 📦 lib-compiler-cranelift About wasmer-compiler-cranelift 📦 lib-compiler-llvm About wasmer-compiler-llvm 📦 lib-deprecated About the deprecated crates 📦 lib-compiler-singlepass About wasmer-compiler-singlepass labels Apr 18, 2019
@bors
Copy link
Contributor

bors bot commented Apr 18, 2019

try

Build failed

@lachlansneff
Copy link
Contributor Author

let's give that another go
bors try

bors bot added a commit that referenced this pull request Apr 18, 2019
@bors
Try #366:
1fbc7c0
@bors
Copy link
Contributor

bors bot commented Apr 18, 2019

try

Build failed

@lachlansneff
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Apr 18, 2019
@bors
Try #366:
2466efb
@lachlansneff
Copy link
Contributor Author

bors try

@bors
Copy link
Contributor

bors bot commented Apr 18, 2019

try

Already running a review

@bors
Copy link
Contributor

bors bot commented Apr 18, 2019

try

Build succeeded

xmclark
xmclark approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@xmclark xmclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@lachlansneff
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Apr 18, 2019
@bors @lachlansneff
Merge #366
b146a9f 
366: Remove UserTrapper trait r=lachlansneff a=lachlansneff

This removes the `UserTrapper` trait and the thread_local EARLY_TRAPPER variable.

Fixes bug reported in #365.

Co-authored-by: Lachlan Sneff <lachlan.sneff@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 18, 2019

Build succeeded

@bors bors bot merged commit 36d73d1 into master Apr 18, 2019
@bors bors bot deleted the fix/early-trapper branch April 18, 2019 17:46
surban pushed a commit to rust-wasi-web/wwrr that referenced this pull request Nov 9, 2024
fix: Bumped the virtual-fs dependency so we get a non-buggy `Static…
47b4633 
…File` implementation (fixes wasmerio#366)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmclark xmclark xmclark approved these changes

Assignees
No one assigned
Labels
bug Something isn't working 📦 lib-compiler-cranelift About wasmer-compiler-cranelift 📦 lib-compiler-llvm About wasmer-compiler-llvm 📦 lib-compiler-singlepass About wasmer-compiler-singlepass 📦 lib-deprecated About the deprecated crates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lachlansneff @xmclark