-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make public API consistent #4398
Conversation
484bed1
to
9b0de3c
Compare
I don't see how. This PR just repositioning the files, creating a |
The problem at hand are the items that are exposed as part of
This PR tries to implement the second solution. Also, in order to prevent this mistake from happening again in the future, it explicitly re-exports everything from the backend. For example, assume we add So in conclusion, this PR makes the api exposed by different backends consistent without a breaking change, and prevents inconsistencies in the future. Note that this PR is marked as draft and isn't still completely ready to be reviewed. |
645e4e2
to
f6818fb
Compare
This PR tries to combine all the suggestions in #4033:
sys
,js
andjsc
behind thebackend
module, it makes sure all three backends expose the same API.stub
module.js
andjsc
use this module to expose the same API assys
by re-exporting items that they don't have an implementation for.#[deprecated]
with re-exports doesn't work in Rust yet and is a known issue. So I didn't have a way to incorporate this suggestion from the original issue.Resolves #4033.