Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(runtime-c-api) Improve error message when instantiating a module #493

Merged
merged 2 commits into from
Jun 14, 2019
Merged

feat(runtime-c-api) Improve error message when instantiating a module #493

merged 2 commits into from
Jun 14, 2019

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Jun 12, 2019

This patch improves the error message returned by wasmer_module_instantiate.

@Hywan Hywan added 🎉 enhancement New feature! 📦 lib-c-api About wasmer-c-api labels Jun 12, 2019
@Hywan Hywan requested a review from bjfish June 12, 2019 09:38
@Hywan Hywan self-assigned this Jun 12, 2019
@Hywan
Copy link
Contributor Author

Hywan commented Jun 12, 2019

bors try

bors bot added a commit that referenced this pull request Jun 12, 2019
@bors
Try #493:
7b4e2b0
@Hywan Hywan mentioned this pull request Jun 12, 2019
Merged
bors bot added a commit to wasmerio/wasmer-go that referenced this pull request Jun 12, 2019
@bors @Hywan
Merge #42
722faa9 
42: feat(instance,module) Improve error messages r=Hywan a=Hywan

Fix #41.

These patches improve error messages when instantiating a module with `Module.Instantiate` or with `NewInstance`.

The error message that is returned by `Module.Instantiate` isn't very helpful, but it's going to change with wasmerio/wasmer#493. Let's wait the next release of the runtime!

Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net>
@bors
Copy link
Contributor

bors bot commented Jun 12, 2019

try

Build succeeded

@Hywan
Copy link
Contributor Author

Hywan commented Jun 14, 2019

bors r+

bors bot added a commit that referenced this pull request Jun 14, 2019
@bors @Hywan
Merge #493
52c02de 
493: feat(runtime-c-api) Improve error message when instantiating a module r=Hywan a=Hywan

This patch improves the error message returned by `wasmer_module_instantiate`.

Co-authored-by: Ivan Enderlin <ivan.enderlin@hoa-project.net>
@bors
Copy link
Contributor

bors bot commented Jun 14, 2019

Build succeeded

@bors bors bot merged commit a6b5eee into wasmerio:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@bjfish bjfish Awaiting requested review from bjfish

Assignees

@Hywan Hywan

Labels
🎉 enhancement New feature! 📦 lib-c-api About wasmer-c-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hywan @syrusakbary