Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup in LLVM backend. #510

Merged
merged 3 commits into from
Jun 26, 2019
Merged

Minor cleanup in LLVM backend. #510

merged 3 commits into from
Jun 26, 2019

Conversation

nlewycky
Copy link
Contributor

  • Simplify construction of floating point constants
  • Fix assertion failure due to definition of %ctx

nlewycky added 2 commits June 25, 2019 16:05
@nlewycky
Void type in llvm may only be used as a function return type. You may…
55394b4 
… not form a pointer to void or use it as a structure member.

Fixes assertion failure initializing llvm backend.
@nlewycky
Simplify construction of floating point constants.
70247a0
@nlewycky nlewycky requested a review from bjfish June 25, 2019 23:07
@syrusakbary
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Jun 26, 2019
@bors
Try #510:
b3455f6
@bors
Copy link
Contributor

bors bot commented Jun 26, 2019

try

Build succeeded

@Hywan
Copy link
Contributor

Hywan commented Jun 26, 2019

Looks good to me.

@Hywan Hywan self-assigned this Jun 26, 2019
@Hywan Hywan added 🎉 enhancement New feature! 📦 lib-compiler-llvm About wasmer-compiler-llvm labels Jun 26, 2019
@Hywan
Copy link
Contributor

Hywan commented Jun 26, 2019 •
edited
Loading

@nlewycky Can you please update the CHANGELOG.md too, and we will be good to merge. Thanks!

@Hywan
Copy link
Contributor

Hywan commented Jun 26, 2019

bors r+

bors bot added a commit that referenced this pull request Jun 26, 2019
@bors @nlewycky
Merge #510
c54a533 
510: Minor cleanup in LLVM backend. r=Hywan a=nlewycky

 - Simplify construction of floating point constants
 - Fix assertion failure due to definition of %ctx

Co-authored-by: Nick Lewycky <nick@wasmer.io>
@bors
Copy link
Contributor

bors bot commented Jun 26, 2019

Build succeeded

@bors bors bot merged commit 1f28800 into master Jun 26, 2019
@bors bors bot deleted the nlewycky/llvm branch June 26, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hywan Hywan Hywan approved these changes

@bjfish bjfish Awaiting requested review from bjfish

Assignees

@Hywan Hywan

Labels
🎉 enhancement New feature! 📦 lib-compiler-llvm About wasmer-compiler-llvm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlewycky @syrusakbary @Hywan