Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve emscripten sockets and networking #514

Merged
merged 3 commits into from
Jul 1, 2019
Merged

improve emscripten sockets and networking #514

merged 3 commits into from
Jul 1, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

No description provided.

@MarkMcCaskey MarkMcCaskey added the 📦 lib-emscripten About wasmer-emscripten label Jun 29, 2019
@MarkMcCaskey MarkMcCaskey changed the title improve emscripten sockets and networking (WIP) improve emscripten sockets and networking Jul 1, 2019
@MarkMcCaskey MarkMcCaskey marked this pull request as ready for review July 1, 2019 20:18
@MarkMcCaskey MarkMcCaskey requested a review from syrusakbary July 1, 2019 20:26
syrusakbary
syrusakbary approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Jul 1, 2019
@bors
Merge #514
fada36a 
514: improve emscripten sockets and networking r=MarkMcCaskey a=MarkMcCaskey



Co-authored-by: Mark McCaskey <mark@wasmer.io>
@bors
Copy link
Contributor

bors bot commented Jul 1, 2019

Build succeeded

@bors bors bot merged commit 6afc2e4 into master Jul 1, 2019
@bors bors bot deleted the feature/improve-emscripten-networking branch July 1, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
📦 lib-emscripten About wasmer-emscripten
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkMcCaskey @syrusakbary