Initial commit of SIMD support in wasmer. #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlewycky
changed the title
bjfish
reviewed
Jul 9, 2019
syrusakbary
reviewed
Jul 9, 2019
The @llvm.minnum/@llvm.maxnum intrinsics don't produce correct (for wasm) outputs in all cases.
…ends don't build.
…pec test. These is one test failure remaining with V128 global variables. * Fix trunc_sat. We need both the largest float that can be converted to an int and the largest int, they are not the same number. * Implement calling of functions that take V128 by passing in two i64's. * Improve support for V128 in spectests. Parse binary modules with the same features as the outer spectest. Fix compilation error involving Result in emitted .rs file. Handle V128 in more cases when producing .rs file. Parse the wast script with SIMD enabled. * Adjust the WAVM spectest so that it parses with WABT and mostly passes with wasmer. Wabt is particular about ints not having decimal places and floats having decimal places. Wasmer does not support mutable globals or shared memory. Tests of shuffles are disabled. Some assert_invalid tests that wabt won't even parse are disabled.
Fixes last spec test failure from the WAVM SIMD spec test.
…ions. Updates to wasmparser 0.34.0 and picks up a newer wasmerio/wabt.
I expect that the V128 changes have broken kernel-loader because I haven't taken care to ensure that the interface was updated the same way on both sides.
|
bors try |
tryBuild failed |
|
bors try |
bjfish
reviewed
Jul 23, 2019
| Operator::I16x8AddSaturateS => { | ||
| let (v1, v2) = state.pop2()?; | ||
| let (v1, v2) = (v1.into_int_value(), v2.into_int_value()); | ||
| let v1 = builder.build_bitcast(v1, intrinsics.i16x8_ty, ""); |
There was a problem hiding this comment.
Should we name all the "" name parameters all over? I thought they may be outputted to ll?
There was a problem hiding this comment.
Depends on LLVM. A debug LLVM preserves instruction names and a release LLVM discards them (the symbol table for instruction names can be rather slow!). Each opcode implementation should copy the state.var_name() to one of the LLVM instructions, and that's usually the same point where we go from naming the rust variable an input value to a result. I think I put names on any instruction that wasn't obvious.
There was a problem hiding this comment.
@bjfish I noticed that there were some opcodes which weren't using the state.var_name() at all. That should be fixed, please point it out if it isn't!
The reason this test needed to be disabled is correctly documented in the comment above.
|
bors try |
syrusakbary
reviewed
Jul 24, 2019
lib/clif-backend/Cargo.toml
Outdated
| cranelift-entity = { version = "0.31" } | ||
| cranelift-frontend = { package = "wasmer-clif-fork-frontend", version = "0.31" } | ||
| cranelift-wasm = { package = "wasmer-clif-fork-wasm", version = "0.31" } | ||
| cranelift-native = { git = "https://github.com/wasmerio/cranelift.git", rev = "060c5a8e3553540144ca08ca028972c57693fa6e" } |
There was a problem hiding this comment.
Can we update the versions of cranelift? (meaning: publishing our forks and use them here).
syrusakbary
reviewed
Jul 24, 2019
tryTimed out |
This test is too large and therefore does not run by default, see `fn is_fat_test` in spectests.rs.
This is needed in order for the resulting wasmer to be releasable.
Co-Authored-By: Syrus Akbary <me@syrusakbary.com>
|
bors try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SIMD support to wasmer, mostly unimplemented. There's an implementation in the LLVM backend, but the other backends are left unimplemented, and the wasmer C API also leaves V128 unimplemented.
Updates to LLVM 8.0.