Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix llvm backend failures in fat spec tests and simd_binaryen spec test. #599

Merged
merged 7 commits into from
Jul 31, 2019
Merged

Fix llvm backend failures in fat spec tests and simd_binaryen spec test. #599

merged 7 commits into from
Jul 31, 2019

Conversation

nlewycky
Copy link
Contributor

No description provided.

nlewycky added 5 commits July 28, 2019 22:53
@nlewycky
LLVM srem is undefined in cases where i32.rem_s and i64.rem_s are def…
2f021f0 
…ined.
@nlewycky
Improve NaN handling by canonicalizing NaNs before most operations.
11f66d2 
Not handled here is @llvm.minnum and @llvm.maxnum which should be replaced with
@llvm.minimum and @llvm.maximum, but using those currently leads to LLVM backend
fatal errors.
@nlewycky
Fix the Trunc[SU] operations, makes conversions.wast pass.
3e7545a
@nlewycky
Fix inkwell assertion due to treating vector as float. Fix llvm backe…
bdb1c4c 
…nd fatal error due to missing support for fminimum/fmaximum.
@nlewycky
Adjust simd_binaryen.wast until it works with LLVM except for known i…
c42f47d 
…ssues.

This doesn't yet work as of this commit, we'll need to pick up a new version of wasmparser.rs too.
syrusakbary
syrusakbary approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@syrusakbary
Copy link
Member

bors r+

@syrusakbary
Copy link
Member

bors cancel

bors bot added a commit that referenced this pull request Jul 30, 2019
@bors @nlewycky
Merge #599
2a7939a 
599: Fix llvm backend failures in fat spec tests and simd_binaryen spec test. r=syrusakbary a=nlewycky



Co-authored-by: Nick Lewycky <nick@wasmer.io>
Co-authored-by: nlewycky <nick@wasmer.io>
@wasmerio wasmerio deleted a comment from bors bot Jul 30, 2019
@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jul 31, 2019
@bors @nlewycky
Merge #599
7106a4f 
599: Fix llvm backend failures in fat spec tests and simd_binaryen spec test. r=syrusakbary a=nlewycky



Co-authored-by: Nick Lewycky <nick@wasmer.io>
Co-authored-by: nlewycky <nick@wasmer.io>
@bors
Copy link
Contributor

bors bot commented Jul 31, 2019

Build succeeded

@bors bors bot merged commit ca4920f into master Jul 31, 2019
@bors bors bot deleted the features/llvm branch July 31, 2019 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@losfair losfair Awaiting requested review from losfair

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlewycky @syrusakbary