runtime-c-api: create the import object separately from instance instantiation #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* import.rs - adding `import_object_t` and `wasmer_import_object_destroy` * instance.rs - adding `wasmer_module_import_instantiate`
* adding `wasmer_import_object_new` and `wasmer_import_object_extend` * adding test file `test-module-import-instantiate.c`
|
bors try |
YaronWittenstein
force-pushed
the
c-api-import_object_t
branch
from
6cc0086 to
18c7f96
Compare
bjfish
approved these changes
Aug 2, 2019
|
LGTM |
bors bot
added a commit
that referenced
this pull request
Aug 2, 2019
616: runtime-c-api: create the import object separately from instance instantiation r=bjfish a=YaronWittenstein Creating an `import object` separately from the `wasmer` instance, let's us build the import object incrementally and support the use-case of having import functions (a.k.a `vmcalls`) implemented in 2 programming languages (Rust and Golang for example) and consumed by the same `wasmer` instance. Co-authored-by: Yaron Wittenstein <yaron.wittenstein@gmail.com> Co-authored-by: Brandon Fish <bjfish@users.noreply.github.com>
YaronWittenstein
added a commit
to spacemeshos/svm
that referenced
this pull request
Aug 4, 2019
* using the new wasmer `wasmer_module_import_instantiate` instead of `wasmer_svm_module_instantiate`. * using `wasmer_import_object_extend` * removed `src/import.rs` (code is has moved to `wasmer-c-api`) see PR: wasmerio/wasmer#616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating an
import objectseparately from thewasmerinstance, let's us build the import object incrementally and support the use-case of having import functions (a.k.avmcalls) implemented in 2 programming languages (Rust and Golang for example) and consumed by the samewasmerinstance.