VM Refactor, new runtime, and the ability to have multiple compilers. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
reviewed
Dec 28, 2018
syrusakbary
reviewed
Dec 28, 2018
src/runtime/backing.rs
Outdated
| GlobalInit::Val(Val::I64(x)) => x as u64, | ||
| GlobalInit::Val(Val::F32(x)) => x as u64, | ||
| GlobalInit::Val(Val::F64(x)) => x, | ||
| GlobalInit::GetGlobal(index) => (imports.globals[index.index()].global).data, |
There was a problem hiding this comment.
I'm not sure I like having a verb (Get) into the struct name.
What you think about using GlobalInit::ImportedGlobal instead ?
There was a problem hiding this comment.
Okay, sounds fine.
There was a problem hiding this comment.
That struct is just exposing instantiation-time initialization, which can either be a const.* or a get_global.
There was a problem hiding this comment.
Maybe *FromGlobal or sth. But that's the name Cranelift used as well.
There was a problem hiding this comment.
I'm just copying the name in the webassembly reference.
bjfish
approved these changes
Jan 20, 2019
bjfish
reviewed
Jan 20, 2019
This reverts commit fbe480c.
nlewycky
pushed a commit
that referenced
this pull request
Aug 13, 2020
Implement extern types in Wasm C API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr rewrites the wasm runtime used by wasmer. It also provides the necessary abstractions to provide multiple compiler backends that feed into the runtime frontend.
I'd like to merge this in the next few days. It can continue to progress while upstream.
Progress:
Emtests(they will be handled in a separate PR)