Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature matrix document #817

Merged
merged 5 commits into from
Sep 23, 2019
Merged

Add feature matrix document #817

merged 5 commits into from
Sep 23, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented Sep 19, 2019 •
edited
Loading

rendered

Review

  • Create a short description of the the change in the CHANGELOG.md file

@MarkMcCaskey MarkMcCaskey added the 📚 documentation Do you like to read? label Sep 19, 2019
syrusakbary
syrusakbary approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good first PR. Perhaps we can use emojis (✅| ✔️, ❌) instead of (Yes, No)

@torch2424
Copy link
Contributor

@syrusakbary

This is a good first PR. Perhaps we can use emojis (✅| ✔️, ❌) instead of (Yes, No)

Hmmm. Do you happen to know how these are read for accessibility? 🤔

But if they are read in a way that makes sense, I think it is a great idea! 😄

@syrusakbary
Copy link
Member

Hmmm. Do you happen to know how these are read for accessibility? 🤔

No idea

@MarkMcCaskey
Copy link
Contributor Author

I checked and the osx screen reader can handle emoji reasonably well

@MarkMcCaskey
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 21, 2019

Merge conflict

@torch2424
Copy link
Contributor

@MarkMcCaskey Thanks for checking Mark! 😄

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Sep 23, 2019
@bors @MarkMcCaskey
Merge #817
23c7b20 
817: Add feature matrix document r=MarkMcCaskey a=MarkMcCaskey

[rendered](https://github.com/wasmerio/wasmer/blob/docs/add-feature-matrix/docs/feature_matrix.md)

# Review

- [x] Create a short description of the the change in the CHANGELOG.md file


Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Sep 23, 2019

Build succeeded

  • wasmerio.wasmer

@bors bors bot merged commit 2ef64b0 into master Sep 23, 2019
@bors bors bot deleted the docs/add-feature-matrix branch September 23, 2019 17:57
@nlewycky nlewycky mentioned this pull request Sep 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
📚 documentation Do you like to read?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkMcCaskey @torch2424 @syrusakbary