Add data and data finalizer to Ctx #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
reviewed
Jan 17, 2019
lib/runtime/src/vm.rs
Outdated
| } | ||
|
|
||
| impl Ctx { | ||
| pub unsafe fn new( | ||
| local_backing: &mut LocalBacking, | ||
| import_backing: &mut ImportBacking | ||
| ) -> Self { |
There was a problem hiding this comment.
It might be a good idea to reuse new_with_data.
Self::new_with_data(local_backing, import_backing, ptr::null_mut(), empty_finalizer)Thoughts?
There was a problem hiding this comment.
@syrusakbary I actually intended new_with_data to be temporary and I forgot to mention that (just trying to prove this concept). The new and new_with_data could be consolidated into new or we could keep new_with_data if you’d like.
There was a problem hiding this comment.
I think we can keep both, but one function reusing the other function so code is not dup.
However I don't have a strong preference, so... your call! :)
MarkMcCaskey
pushed a commit
that referenced
this pull request
Apr 14, 2020
nlewycky
pushed a commit
that referenced
this pull request
Aug 13, 2020
Fix repeated typo "funciton".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.