Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libm to fix floating point panics for debug no_std builds #240

Closed
kettle11 opened this issue Nov 2, 2020 · 0 comments
Closed

Update libm to fix floating point panics for debug no_std builds #240

kettle11 opened this issue Nov 2, 2020 · 0 comments

Comments

@kettle11
Copy link

kettle11 commented Nov 2, 2020

On the README there's this note:

Floating point operations in no_std use libm, which sometimes panics in debug mode (rust-lang/libm#4). So make sure to either use release builds or avoid WASM with floating point operations, for example by using deny_floating_point.

The linked issue(rust-lang/libm#4) was resolved a while back, so wasmi can update the version of libm to fix the problematic behavior described in the above quote.
brson added a commit to brson/wasmi that referenced this issue Nov 29, 2020
@brson
Upgrade libm to 0.2.1
bdf3ece 
Fixes wasmi-labs#240

Signed-off-by: Brian Anderson <andersrb@gmail.com>
@brson brson mentioned this issue Nov 29, 2020
Merged
@Robbepop Robbepop mentioned this issue Sep 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kettle11