Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly mirror Wasmtime fuel API #1002

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Apr 24, 2024

  • Remove Store::{add_fuel, consume_fuel}
  • Remove Caller::{add_fuel, consume_fuel}
  • Add Store::{get_fuel, set_fuel}
  • Add Caller::{get_fuel, set_fuel}
  • Add StoreContext::get_fuel
  • Add StoreContextMut::{get_fuel, set_fuel}

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 81.77%. Comparing base (18807fb) to head (39a4855).
Report is 2 commits behind head on master.

Files Patch % Lines
crates/wasmi/src/store.rs 66.66% 6 Missing ⚠️
crates/cli/src/main.rs 0.00% 4 Missing ⚠️
crates/wasmi/src/func/caller.rs 0.00% 4 Missing ⚠️
crates/cli/src/context.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1002   +/-   ##
=======================================
  Coverage   81.76%   81.77%           
=======================================
  Files         262      262           
  Lines       24327    24378   +51     
=======================================
+ Hits        19892    19936   +44     
- Misses       4435     4442    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit d5f3a66 into master Apr 24, 2024
16 of 17 checks passed
@Robbepop Robbepop deleted the rf-mirror-wasmtime-fuel-api branch April 24, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant