-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wasmi_collections
crate
#1007
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all definitions into an arena submodule.
Inspired by wasmparser. Will be used in later commits.
Inspired by wasmparser::collections module.
Also forward this crate feature to wasmi_collections.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1007 +/- ##
==========================================
- Coverage 81.75% 80.74% -1.01%
==========================================
Files 264 269 +5
Lines 24445 24785 +340
==========================================
+ Hits 19984 20012 +28
- Misses 4461 4773 +312 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the old
wasmi_arena
crate with a more versatile and generalwasmi_collections
crate.Inspired by
wasmparser
's upcomingcollections
module found here: bytecodealliance/wasm-tools#1521This allows Wasmi to be run as efficiently as possible in all supported environments via the new
no-hash-maps
crate feature which can be used to toggleHashMap
orBTreeMap
usage within the entire Wasmi crate.