Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasmi_collections crate #1007

Merged
merged 21 commits into from
Apr 30, 2024
Merged

Add wasmi_collections crate #1007

merged 21 commits into from
Apr 30, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Apr 30, 2024

This replaces the old wasmi_arena crate with a more versatile and general wasmi_collections crate.
Inspired by wasmparser's upcoming collections module found here: bytecodealliance/wasm-tools#1521

This allows Wasmi to be run as efficiently as possible in all supported environments via the new no-hash-maps crate feature which can be used to toggle HashMap or BTreeMap usage within the entire Wasmi crate.

image

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 8.50440% with 312 lines in your changes are missing coverage. Please review.

Project coverage is 80.74%. Comparing base (492be5a) to head (818994f).

Files Patch % Lines
crates/collections/src/map.rs 8.63% 127 Missing ⚠️
crates/collections/src/set.rs 0.00% 87 Missing ⚠️
crates/collections/src/string_interner/detail.rs 0.00% 62 Missing ⚠️
crates/collections/src/hash.rs 47.05% 18 Missing ⚠️
crates/collections/src/string_interner.rs 0.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
- Coverage   81.75%   80.74%   -1.01%     
==========================================
  Files         264      269       +5     
  Lines       24445    24785     +340     
==========================================
+ Hits        19984    20012      +28     
- Misses       4461     4773     +312     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 7045984 into master Apr 30, 2024
15 of 17 checks passed
@Robbepop Robbepop deleted the rf-wasmi-collections branch April 30, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant