-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Wasmi and Wasmtime API mirroring with renamings #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this improves mirroring between Wasmi and Wasmtime.
Following steps with Value to Val renaming.
Following Value to Val renaming.
Improves Wasmi and Wasmtime mirroring.
Improves Wasmi and Wasmtime mirroring.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1011 +/- ##
==========================================
+ Coverage 80.65% 80.68% +0.03%
==========================================
Files 269 269
Lines 24813 24775 -38
==========================================
- Hits 20012 19990 -22
+ Misses 4801 4785 -16 ☔ View full report in Codecov by Sentry. |
Robbepop
changed the title
Improve Wasmi and Wasmtime API mirroring
Improve Wasmi and Wasmtime API mirroring with renamings
May 2, 2024
Details can be found in the PR description.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config::engine_limits
method ->enforced_limits
Value
enum ->Val
ValueType
enum ->ValType
UntypedValue
struct ->UntypedVal
WasmType
trait ->WasmTy
AsContext::UserState
assoc. type ->Data