Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement some minor UX improvements #1031

Merged
merged 4 commits into from
May 12, 2024
Merged

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented May 12, 2024

  • Implement Default for Store<T> where T: Default.
    • This serves a purpose for a simple Wasmi setup.
  • Implement WasmTy for f32 and f64.
    • This allows to use f32 and f64 instead of F32 and F64 for APIs such as func_wrap.
  • Enable Config::tail_call and Config::extended_const by default.
    • Those Wasm proposals have been moved to phase 4 for many months now.

Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 80.82%. Comparing base (26ea8ad) to head (4a9f742).

Files Patch % Lines
crates/wasmi/src/store.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
- Coverage   80.83%   80.82%   -0.01%     
==========================================
  Files         269      269              
  Lines       24803    24806       +3     
==========================================
  Hits        20049    20049              
- Misses       4754     4757       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 5c17423 into master May 12, 2024
16 of 18 checks passed
@Robbepop Robbepop deleted the rf-impl-default-for-store branch May 12, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant