-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-streaming Wasm module creation #1035
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are guaranteed that only Payload::CodeSectionEntry follows until the code section is done.
It will be handling both streaming and buffered Wasm module parsing.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1035 +/- ##
==========================================
+ Coverage 80.82% 80.86% +0.03%
==========================================
Files 269 271 +2
Lines 24825 24896 +71
==========================================
+ Hits 20065 20132 +67
- Misses 4760 4764 +4 ☔ View full report in Codecov by Sentry. |
It should be the new default when applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far Wasmi only supported streaming parsing, validation and compilation of Wasm modules via
Module::new
.This PR renames both
Module::new
andModule::new_unchecked
tonew_streaming
andnew_streaming_unchecked
respectively. Also it adds 2 new methodsModule::new
andModule::new_unchecked
that take awasm: &[u8]
byte slice argument instead of astream: impl Read
argument. The idea behind this change is that if streaming compilation is not necessary we can optimize the process.Benchmarks
The benchmarks locally show amazing performance wins across the board.
For
lazy
and especiallylazy-unchecked
compilation I consistently saw improvements between 40-80% (5x speed-up).