Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Memory API #1082

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Improve Memory API #1082

merged 5 commits into from
Jun 24, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Jun 23, 2024

  • Adds Memory::{data_ptr, data_size}
  • Changes return type of Memory::grow from Pages to u32
  • Changes additional parameter type from Pages to u32
  • Remove Memory::current_pages method
  • Add Memory::size method

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.48%. Comparing base (d088395) to head (dd4f849).

Files Patch % Lines
crates/wasmi/src/memory/mod.rs 56.25% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
- Coverage   80.50%   80.48%   -0.03%     
==========================================
  Files         269      269              
  Lines       24992    24998       +6     
==========================================
- Hits        20120    20119       -1     
- Misses       4872     4879       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit f1f92e4 into master Jun 24, 2024
16 of 18 checks passed
@Robbepop Robbepop deleted the rf-better-memory-api-mirror branch June 24, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant