Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error for Rust versions <1.78 #1093

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Jun 30, 2024

Closes #1091.

This can be reverted once Wasmi's MSRV is bumped to Rust 1.78 or higher.

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.48%. Comparing base (aa007b4) to head (1f6cb04).

Files Patch % Lines
crates/wasmi/src/engine/executor/cache.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
- Coverage   80.48%   80.48%   -0.01%     
==========================================
  Files         270      270              
  Lines       25080    25080              
==========================================
- Hits        20186    20185       -1     
- Misses       4894     4895       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 0df1722 into master Jun 30, 2024
16 of 18 checks passed
@Robbepop Robbepop deleted the rf-fix-wasmi-compilation-for-rust.177 branch June 30, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to install wasmi_cli: raw mutable pointers are not allowed in statics (Rust 1.77.1)
1 participant