-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to compile Wasm modules in host functions called from the Wasmi executor (take 2) #1122
Conversation
This makes it possible to compile Wasm modules from host functions called from Wasm.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
+ Coverage 80.51% 80.54% +0.03%
==========================================
Files 271 272 +1
Lines 25110 25088 -22
==========================================
- Hits 20217 20208 -9
+ Misses 4893 4880 -13 ☔ View full report in Codecov by Sentry. |
Due to the progress in optimizing the |
Closes #631.
This is another relatively naive fix for #631. It heavily refactors the
CodeMap
to no longer use atomics for synchronization but a globalMutex
. The idea behind this is that this is the lowest we can get with simple synchronization locks. If this technique does not suffice the performance needs, we need to look elsewhere.Benchmarks comparing this PR with
main
:Rust-sourced benchmarks do not significantly regress:
Call-intense benchmark regress as expected:
Other benchmarks are also not signficantly affected: