Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
CodeMap::alloc_funcs
replaces theCodeMap::alloc_func
API.The advantage is that fewer
CodeMap
locks are required to allocate multipleEngineFunc
at the same time which is the only wayCodeMap::alloc_func
was used.Also this PR introduces the new
EngineFuncSpan
andEngineFuncSpanIter
abstractions which significantly improve space efficiency of storing newly allocated contiguousEngineFunc
indices returned byCodeMap::alloc_funcs
.This allowed us to optimize the way
ModuleHeader
andModuleBuilder
store and manage allocatedEngineFunc
s.Benchmarks conducted locally confirm that this is a huge performance improvement, especially for lazy Wasm module compilation: