Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Error instead of FuelError from Store::get/set_fuel APIs #1131

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Jul 17, 2024

Required for #1009 to simplify API surface.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.56%. Comparing base (258bfd2) to head (1d1e01e).

Files Patch % Lines
crates/wasmi/src/store.rs 57.14% 3 Missing ⚠️
crates/wasmi/src/func/caller.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1131   +/-   ##
=======================================
  Coverage   80.56%   80.56%           
=======================================
  Files         273      273           
  Lines       25085    25085           
=======================================
  Hits        20210    20210           
  Misses       4875     4875           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit e355a14 into main Jul 17, 2024
17 of 18 checks passed
@Robbepop Robbepop deleted the rf-ret-error-instead-of-fuelerror branch July 17, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant