Remove unnecessary extend instructions #1147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Wasm
i64_extend_i32_u
andi64_extend_i32_s
instructions are unnecessary in Wasmi bytecode.i64_extend_i32_u
instruction is essentially a no-op in an untyped bytecode.i64_extend_i32_s
instruction can be replaced by thei64_extend32_s
instruction since Wasmi bytecode is untyped and the only difference between these two instructions is their effect on the type system.Technically the
i32_wrap_i64 x
instruction could be replaced byi64.and x 0xFFFF_FFFF
but due to Wasmi's current bytecode encoding this replacement representation would require substantially more encoding space and was less efficient.