-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce cmp
and cmp+br
instructions
#1243
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1243 +/- ##
==========================================
- Coverage 81.77% 81.44% -0.34%
==========================================
Files 304 304
Lines 25144 25036 -108
==========================================
- Hits 20561 20390 -171
- Misses 4583 4646 +63 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a bit of trouble with the executor, as I am less experienced at that part, but it I couldn't see anything that looked wrong. The rest of the code ir
, executor
, instrs
, tests
I was more thorough and understood better and all looks good to me!
Thank you for the code review @dkcumming ! 🚀 Really appreciate it. |
This reduces
i{32,64}.{gt,ge}_{s,u}
andf{32,64}.{gt,ge}
instructions into respective{lt,le}
variants.Fused
cmp+br
instructions are also affected by the above change.To support this, new
{lt,le}
variants with 16-bit immediatelhs
values have been added.Overall this reduces the total amount of Wasmi instructions by 24 which is quite significant.
Local benchmarks show significant improvements across the board: