Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove core crate feature #272

Merged
merged 15 commits into from
Dec 8, 2021
Merged

Remove core crate feature #272

merged 15 commits into from
Dec 8, 2021

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Dec 8, 2021

Closes #270.

In summary this PR does the following:

  • Removes the core crate feature. Explanation can be found in Remove core feature #270 .
  • Replaces the vec_memory crate feature with the new virtual_memory crate feature.
    • The reason is that the new virtual_memory crate feature is additive unlike the old vec_memory.
    • Users of the crate are recommended to enable the virtual_memory crate feature if they are building wasmi for a platform that supports OS based virtual memory. Otherwise wasmi will fallback onto the vector based implementation.

@Robbepop Robbepop changed the title Rf remove core feature Remove core feature Dec 8, 2021
@Robbepop Robbepop requested a review from athei December 8, 2021 10:50
@Robbepop Robbepop changed the title Remove core feature Remove core crate feature Dec 8, 2021
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/memory/mod.rs Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
src/memory/mmap_bytebuf.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@Robbepop Robbepop merged commit 9432d81 into master Dec 8, 2021
@kpp kpp deleted the rf-remove-core-feature branch December 10, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove core feature
3 participants