Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: pin windows-latest to windows-2019 #352

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Conversation

rcny
Copy link
Contributor

@rcny rcny commented Feb 1, 2022

This PR can be used as the possible temporary fix until the project's dependencies will be able to compile on windows-2022.

@codecov-commenter
Copy link

Codecov Report

Merging #352 (f2ed48f) into master (3ff9241) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   80.76%   80.76%           
=======================================
  Files          79       79           
  Lines        9513     9513           
=======================================
  Hits         7683     7683           
  Misses       1830     1830           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff9241...f2ed48f. Read the comment docs.

@rcny rcny requested a review from Robbepop February 1, 2022 23:19
@Robbepop
Copy link
Member

Robbepop commented Feb 2, 2022

Thank you for the PR. So unfortunately the wabt dependency causes the trouble.
The good thing is that we are already planning on phasing it out in wasmi_v1. The bad thing is that this process will probably take a while to complete.
Until then I guess we unfortunately need to deal with this heavily outdated windows experience.

@rcny
Copy link
Contributor Author

rcny commented Feb 2, 2022

Not sure that windows-2019 is already outdated. It has mainstream support until the beginning of 2024 and e.g. Rust team is only planning migration to windows-2022.

Copy link
Member

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing the CI.
We really should get wabt as dependency out of this library. While windows-2019 will be supported for quite some time we want to always be working on the latest versions.

@Robbepop Robbepop merged commit bc2993d into master Feb 3, 2022
@athei athei deleted the vi-pin-windows-2019 branch July 26, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants