Optimize global.get
and global.set
execution
#427
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
global.get
and especiallyglobal.set
perform a lot of unnecessary conversions and checks.For example
global.set
checks for global variable mutability and checks types even though that has already been done during Wasm validation at the time ofwasmi
bytecode execution.This also adds a new benchmark to test global variable
set
andget
performance and shows a roughly 17% performance boost.