-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize for common drop_keep
cases in wasmi
executor
#493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my local machine I am observing speed ups up to 10% especially for call intense workloads. Unfortunately our benchmarking CI cannot confirm this right now. |
Robbepop
changed the title
[WIP] Optimize jumps that keep zero elements on the stack (take 2)
Optimize jumps that keep zero elements on the stack (take 2)
Oct 2, 2022
Robbepop
changed the title
Optimize jumps that keep zero elements on the stack (take 2)
Optimize for common Oct 2, 2022
drop_keep
cases in wasmi
executor
BENCHMARKS
|
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
==========================================
+ Coverage 79.18% 79.20% +0.01%
==========================================
Files 74 74
Lines 6309 6314 +5
==========================================
+ Hits 4996 5001 +5
Misses 1313 1313
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The procedures to keep values is pretty expensive when in the case where no values shall be kept so we bail out early for some nice and easy performance gains in some cases.
Robbepop
force-pushed
the
rf-optimize-branch-dropkeep-v2
branch
from
October 4, 2022 09:28
967fdb8
to
edcd580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a result of an observation that we could speed-up execution of branch and return instructions that keep no values or just a single value upon jump. Especially in the Wasm MVP those two cases are the common ones.
This is take 2 after the first experiment yielded really bad results: #492