Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: retry CI twice on every type of failure #509

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Conversation

sergejparity
Copy link
Contributor

Sometimes CI fails due to ad hoc network issues like here https://gitlab.parity.io/parity/mirrors/wasmi/-/jobs/1940274 which can be fixed just by restarting job. And we have such setting in place - retry block, but for some reason GitLab fails to match above mentioned events to when rules runner_system_failure, unknown_failure, api_failure

This PR introduces functionality to make 2 additional attempts in case if CI job fails. Use default when: always implicitly.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
count_until
888.57µs 888.46µs ⚪ 0.03% 2.38ms 2.38ms ⚪ -0.09% 🔴 168%
execute/
factorial_iterative
400.65ns 400.76ns ⚪ 0.04% 996.17ns 992.28ns ⚪ -0.39% 🔴 148%
execute/
factorial_recursive
800.65ns 761.82ns 🟢 -4.86% 1.55µs 1.55µs ⚪ -0.13% 🔴 104%
execute/
fib_iterative
1.80ms 1.79ms ⚪ -0.10% 5.11ms 5.19ms 🔴 1.66% 🔴 190%
execute/
fib_recursive
6.90ms 6.80ms 🟢 -1.45% 14.42ms 14.03ms 🟢 -2.65% 🔴 106%
execute/
global_bump
1.43ms 1.43ms ⚪ 0.01% 3.64ms 3.63ms ⚪ -0.22% 🔴 153%
execute/
host_calls
32.93µs 31.83µs ⚪ -1.92% 45.06µs 45.00µs ⚪ -0.13% 🟢 41%
execute/
memory_fill
1.54ms 1.54ms ⚪ 0.03% 4.33ms 4.32ms ⚪ 0.00% 🔴 181%
execute/
memory_sum
1.52ms 1.52ms ⚪ 0.06% 4.36ms 4.36ms ⚪ -0.04% 🔴 187%
execute/
memory_vec_add
3.05ms 3.05ms ⚪ 0.08% 8.94ms 8.99ms ⚪ 0.21% 🔴 195%
execute/
recursive_is_even
1.30ms 1.29ms ⚪ -0.39% 2.61ms 2.53ms 🟢 -2.98% 🟡 96%
execute/
recursive_ok
173.96µs 173.64µs ⚪ -0.16% 348.90µs 348.57µs ⚪ -0.11% 🔴 101%
execute/
recursive_scan
213.72µs 212.35µs ⚪ -0.31% 455.10µs 451.12µs ⚪ -0.81% 🔴 112%
execute/
recursive_trap
17.38µs 17.35µs ⚪ -0.15% 35.97µs 34.91µs 🟢 -2.71% 🔴 101%
execute/
regex_redux
664.78µs 655.52µs ⚪ -1.29% 1.61ms 1.60ms ⚪ -0.80% 🔴 144%
execute/
rev_complement
601.64µs 592.87µs 🟢 -1.42% 1.55ms 1.55ms ⚪ 0.05% 🔴 162%
execute/
tiny_keccak
461.56µs 465.56µs ⚪ 0.66% 1.41ms 1.46ms 🔴 4.24% 🔴 215%
execute/
trunc_f2i
1.13ms 1.07ms ⚪ -2.30% 2.72ms 2.72ms ⚪ 0.11% 🔴 154%
instantiate/
wasm_kernel
69.59µs 71.78µs ⚪ 2.87% 127.22µs 95.79µs 🟢 -24.75% 🟢 33%
translate/
wasm_kernel
4.95ms 5.00ms ⚪ -0.03% 9.35ms 9.42ms ⚪ 0.91% 🟡 88%

Link to pipeline

@codecov-commenter
Copy link

Codecov Report

Merging #509 (4e6a3b9) into master (21e12da) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #509   +/-   ##
=======================================
  Coverage   79.23%   79.23%           
=======================================
  Files          74       74           
  Lines        6313     6313           
=======================================
  Hits         5002     5002           
  Misses       1311     1311           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robbepop Robbepop merged commit cf1378b into master Oct 12, 2022
@Robbepop Robbepop deleted the sk-tune-ci-retry branch October 12, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants