Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add miri check #523

Merged
merged 1 commit into from
Oct 18, 2022
Merged

CI: add miri check #523

merged 1 commit into from
Oct 18, 2022

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Oct 18, 2022

Due to use of unsafe Rust it is useful to have miri testing for the wasmi workspace.
Unfortunately this does not (yet) test the extensive Wasm spec test suite but runs only the library unit tests of the entire workspace.
We might be required to either refactor how the Wasm spec test suite works or add some execution unit tests.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.27ms 1.27ms ⚪ 0.01% 1.06ms 1.06ms 🟢 0.06% 🟢 -16%
execute/
bare_call_0/typed
698.49µs 698.46µs ⚪ -0.01% 524.98µs 518.80µs 🟢 -1.18% 🟢 -26%
execute/
bare_call_1
1.46ms 1.39ms 🟢 -4.85% 1.31ms 1.31ms ⚪ -0.02% 🟢 -6%
execute/
bare_call_16
3.02ms 2.95ms 🟢 -2.25% 4.99ms 4.98ms ⚪ -0.12% 🟡 69%
execute/
bare_call_16/typed
1.32ms 1.32ms ⚪ -0.39% 2.34ms 2.32ms ⚪ -0.76% 🟡 76%
execute/
bare_call_1/typed
727.74µs 729.41µs ⚪ 0.29% 673.32µs 673.67µs ⚪ 0.04% 🟢 -8%
execute/
bare_call_4
1.83ms 1.74ms 🟢 -4.77% 2.07ms 2.06ms ⚪ -0.24% 🟢 19%
execute/
bare_call_4/typed
888.26µs 892.48µs ⚪ 0.47% 966.03µs 964.09µs ⚪ -0.12% 🟢 8%
execute/
count_until
935.00µs 918.23µs 🟢 -1.82% 2.38ms 2.38ms ⚪ -0.05% 🔴 159%
execute/
factorial_iterative
395.56ns 396.66ns ⚪ 0.25% 988.73ns 989.18ns ⚪ 0.03% 🔴 149%
execute/
factorial_recursive
804.17ns 782.22ns ⚪ -1.72% 1.64µs 1.59µs 🟢 -3.16% 🔴 104%
execute/
fib_iterative
1.86ms 1.86ms ⚪ 0.05% 5.11ms 5.11ms ⚪ 0.02% 🔴 174%
execute/
fib_recursive
7.27ms 7.26ms ⚪ -0.25% 14.20ms 14.19ms ⚪ -0.15% 🟡 95%
execute/
global_bump
1.34ms 1.33ms ⚪ -0.30% 3.66ms 3.65ms ⚪ -0.13% 🔴 174%
execute/
host_calls
31.82µs 32.37µs ⚪ 1.05% 49.35µs 44.72µs 🟢 -9.52% 🟢 38%
execute/
memory_fill
1.70ms 1.70ms ⚪ 0.03% 4.33ms 4.33ms ⚪ 0.05% 🔴 155%
execute/
memory_sum
1.65ms 1.59ms ⚪ -2.05% 4.36ms 4.36ms ⚪ 0.04% 🔴 175%
execute/
memory_vec_add
3.17ms 3.16ms ⚪ -0.52% 8.93ms 8.96ms ⚪ 0.32% 🔴 183%
execute/
recursive_is_even
1.35ms 1.36ms ⚪ 0.64% 2.57ms 2.57ms ⚪ 0.08% 🟡 89%
execute/
recursive_ok
183.89µs 182.95µs ⚪ -0.57% 353.82µs 353.27µs ⚪ -0.20% 🟡 93%
execute/
recursive_scan
220.62µs 218.73µs ⚪ -1.05% 459.75µs 459.28µs ⚪ -0.11% 🔴 110%
execute/
recursive_trap
18.22µs 17.21µs 🟢 -5.63% 35.75µs 35.52µs ⚪ -0.54% 🔴 106%
execute/
regex_redux
703.30µs 700.90µs ⚪ -0.40% 1.59ms 1.60ms ⚪ 0.42% 🔴 128%
execute/
rev_complement
626.35µs 620.45µs ⚪ -0.99% 1.56ms 1.56ms ⚪ 0.02% 🔴 151%
execute/
tiny_keccak
496.59µs 486.31µs 🟢 -1.64% 1.43ms 1.42ms ⚪ -0.19% 🔴 192%
execute/
trunc_f2i
1.02ms 1.02ms ⚪ -0.10% 2.72ms 2.72ms ⚪ -0.03% 🔴 167%
instantiate/
wasm_kernel
67.34µs 66.55µs ⚪ -1.02% 126.89µs 94.09µs 🟢 -25.71% 🟢 41%
translate/
wasm_kernel
4.82ms 4.83ms ⚪ 0.15% 9.57ms 10.36ms 🔴 8.41% 🔴 115%

Link to pipeline

@codecov-commenter
Copy link

Codecov Report

Merging #523 (139814f) into master (b11271f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   79.38%   79.38%           
=======================================
  Files          74       74           
  Lines        6278     6278           
=======================================
  Hits         4984     4984           
  Misses       1294     1294           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robbepop Robbepop merged commit dab2565 into master Oct 18, 2022
@Robbepop Robbepop deleted the rf-add-miri-ci branch October 18, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants