Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Store Send and Sync #566

Merged
merged 5 commits into from
Nov 18, 2022
Merged

Make Store Send and Sync #566

merged 5 commits into from
Nov 18, 2022

Conversation

Robbepop
Copy link
Member

Closes #565.

@paritytech-cicd-pr
Copy link

paritytech-cicd-pr commented Nov 18, 2022

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.04ms 1.01ms 🟢 -2.99% 1.03ms 898.97µs 🟢 -12.73% 🟢 -11%
execute/
bare_call_0/typed
546.36µs 513.40µs 🟢 -5.64% 404.80µs 401.04µs ⚪ -0.97% 🟢 -22%
execute/
bare_call_1
1.05ms 1.06ms ⚪ 1.66% 1.08ms 1.08ms 🟢 -0.16% 🟢 2%
execute/
bare_call_16
2.20ms 2.19ms ⚪ -0.26% 4.77ms 4.75ms 🟢 -0.48% 🔴 117%
execute/
bare_call_16/typed
1.55ms 1.55ms ⚪ 0.16% 2.22ms 2.01ms 🟢 -9.17% 🟢 30%
execute/
bare_call_1/typed
602.18µs 607.92µs ⚪ 0.98% 699.73µs 709.58µs ⚪ 1.18% 🟢 17%
execute/
bare_call_4
1.21ms 1.19ms 🟢 -0.45% 1.74ms 1.74ms 🟢 0.42% 🟢 46%
execute/
bare_call_4/typed
642.24µs 616.75µs 🟢 -3.87% 853.01µs 800.54µs 🟢 -6.20% 🟢 30%
execute/
br_table
643.44µs 634.47µs ⚪ -1.74% 927.27µs 899.79µs 🟢 -2.82% 🟢 42%
execute/
count_until
754.76µs 650.24µs 🟢 -13.90% 2.06ms 2.06ms ⚪ -0.11% 🔴 218%
execute/
factorial_iterative
310.33µs 410.70µs 🔴 32.36% 846.68µs 845.53µs ⚪ -0.15% 🔴 106%
execute/
factorial_recursive
623.12µs 612.12µs 🟢 -1.80% 1.25ms 1.25ms ⚪ -0.55% 🔴 104%
execute/
fib_iterative
1.54ms 1.54ms ⚪ 0.04% 4.46ms 4.46ms ⚪ -0.06% 🔴 188%
execute/
fib_recursive
5.77ms 5.81ms ⚪ 0.98% 11.56ms 11.34ms 🟢 -1.92% 🟡 95%
execute/
global_bump
954.00µs 954.99µs ⚪ 0.11% 3.16ms 3.16ms ⚪ -0.10% 🔴 231%
execute/
global_const
830.92µs 799.00µs ⚪ -3.59% 2.32ms 2.38ms ⚪ 3.15% 🔴 198%
execute/
host_calls
28.77µs 29.11µs 🔴 1.25% 39.64µs 38.05µs 🟢 -3.77% 🟢 31%
execute/
memory_fill
1.30ms 1.30ms ⚪ -0.09% 3.98ms 4.00ms ⚪ 0.34% 🔴 207%
execute/
memory_sum
1.33ms 1.33ms ⚪ 0.53% 3.95ms 3.94ms ⚪ -0.07% 🔴 196%
execute/
memory_vec_add
2.73ms 2.73ms ⚪ -0.03% 8.19ms 8.18ms ⚪ -0.08% 🔴 200%
execute/
recursive_is_even
1.11ms 1.11ms ⚪ -0.48% 2.21ms 2.10ms 🟢 -5.15% 🟡 89%
execute/
recursive_ok
142.24µs 143.17µs ⚪ 0.55% 318.36µs 293.44µs 🟢 -7.90% 🔴 105%
execute/
recursive_scan
178.11µs 179.10µs ⚪ 0.62% 377.24µs 373.73µs ⚪ -0.96% 🔴 109%
execute/
recursive_trap
13.96µs 14.02µs ⚪ 0.40% 28.40µs 28.26µs ⚪ -0.52% 🔴 102%
execute/
regex_redux
549.57µs 545.23µs ⚪ -0.83% 1.45ms 1.45ms ⚪ 5.18% 🔴 167%
execute/
rev_complement
526.08µs 515.72µs 🟢 -1.87% 1.43ms 1.43ms ⚪ -0.07% 🔴 178%
execute/
tiny_keccak
370.84µs 374.21µs ⚪ 0.83% 1.21ms 1.20ms ⚪ -0.13% 🔴 222%
execute/
trunc_f2i
913.34µs 912.99µs ⚪ 0.03% 2.43ms 2.43ms ⚪ -0.15% 🔴 166%
instantiate/
wasm_kernel
60.80µs 59.85µs ⚪ -0.64% 96.36µs 65.58µs 🟢 -31.48% 🟢 10%
translate/
erc1155
209.71µs 207.70µs ⚪ 0.10% 384.44µs 387.78µs ⚪ 0.85% 🟡 87%
translate/
erc20
100.96µs 101.92µs ⚪ 1.10% 185.24µs 189.66µs 🔴 2.50% 🟡 86%
translate/
erc721
144.67µs 146.94µs ⚪ 1.38% 271.67µs 274.46µs ⚪ 1.03% 🟡 87%
translate/
spidermonkey
72.25ms 0.00ns ⚪ 0.46% 0.00ns 0.00ns 🔴 1.39% 🟢 0%
translate/
wasm_kernel
3.75ms 3.78ms ⚪ 1.04% 7.19ms 7.27ms ⚪ 1.15% 🟡 92%

Link to pipeline

@codecov-commenter
Copy link

Codecov Report

Merging #566 (1f3d373) into master (93c1596) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #566   +/-   ##
=======================================
  Coverage   80.03%   80.04%           
=======================================
  Files          78       78           
  Lines        6322     6323    +1     
=======================================
+ Hits         5060     5061    +1     
  Misses       1262     1262           
Impacted Files Coverage Δ
crates/arena/src/lib.rs 50.81% <ø> (ø)
crates/wasmi/src/engine/code_map.rs 81.57% <ø> (ø)
crates/wasmi/src/store.rs 74.24% <100.00%> (+0.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robbepop Robbepop merged commit 44419e0 into master Nov 18, 2022
@Robbepop Robbepop deleted the rf-make-store-send-sync branch November 18, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Store is not Send nor Sync.
3 participants