Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup VisitOperator trait impl via macro #644

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Feb 2, 2023

No description provided.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.40ms 1.40ms ⚪ -0.09% 1.24ms 1.16ms 🟢 -5.73% 🟢 -17%
execute/
bare_call_0/typed
1.03ms 1.02ms ⚪ -0.64% 788.23µs 772.78µs 🟢 -1.90% 🟢 -24%
execute/
bare_call_1
1.45ms 1.68ms 🔴 16.04% 1.44ms 1.36ms 🟢 -5.34% 🟢 -19%
execute/
bare_call_16
2.42ms 2.37ms 🟢 -2.20% 4.68ms 4.60ms 🟢 -1.71% 🟡 94%
execute/
bare_call_16/typed
1.79ms 1.79ms ⚪ 0.18% 2.80ms 2.78ms ⚪ -0.57% 🟡 55%
execute/
bare_call_1/typed
1.14ms 1.15ms ⚪ 0.95% 1.15ms 1.15ms ⚪ 0.41% 🟢 0%
execute/
bare_call_4
1.62ms 1.62ms 🟢 0.00% 2.07ms 2.03ms 🟢 -1.77% 🟢 25%
execute/
bare_call_4/typed
1.15ms 1.14ms 🟢 -1.31% 1.31ms 1.32ms ⚪ 0.69% 🟢 16%
execute/
br_table
1.18ms 1.16ms 🟢 -2.27% 1.38ms 1.37ms ⚪ -0.51% 🟢 18%
execute/
count_until
683.28µs 683.06µs ⚪ -0.08% 2.11ms 2.12ms ⚪ 0.90% 🔴 210%
execute/
factorial_iterative
328.31µs 325.13µs ⚪ -1.01% 947.88µs 954.51µs ⚪ 0.60% 🔴 194%
execute/
factorial_recursive
659.89µs 664.36µs ⚪ 0.66% 1.35ms 1.35ms ⚪ 0.44% 🔴 104%
execute/
fib_iterative
1.40ms 1.40ms ⚪ -0.03% 5.14ms 5.15ms ⚪ 0.15% 🔴 268%
execute/
fib_recursive
5.99ms 5.96ms ⚪ -0.17% 11.75ms 11.73ms ⚪ -0.17% 🟡 97%
execute/
global_bump
984.53µs 983.30µs ⚪ -0.21% 2.44ms 2.45ms ⚪ 0.17% 🔴 149%
execute/
global_const
742.80µs 742.15µs ⚪ -0.10% 2.55ms 2.55ms ⚪ 0.02% 🔴 244%
execute/
host_calls
26.57µs 29.22µs 🔴 12.01% 40.21µs 39.86µs ⚪ -1.03% 🟢 36%
execute/
memory_fill
1.25ms 1.25ms ⚪ 0.05% 4.16ms 4.15ms ⚪ -0.12% 🔴 231%
execute/
memory_sum
1.35ms 1.20ms 🟢 -9.80% 4.17ms 4.15ms ⚪ -0.10% 🔴 246%
execute/
memory_vec_add
2.60ms 2.60ms ⚪ 0.06% 7.59ms 7.60ms ⚪ 0.14% 🔴 192%
execute/
recursive_is_even
1.17ms 1.13ms 🟢 -3.82% 2.30ms 2.31ms ⚪ 0.36% 🔴 105%
execute/
recursive_ok
165.89µs 160.10µs 🟢 -3.50% 312.04µs 315.12µs ⚪ 0.99% 🟡 97%
execute/
recursive_scan
195.32µs 189.81µs ⚪ -3.03% 374.90µs 380.01µs 🔴 1.39% 🟡 100%
execute/
recursive_trap
16.32µs 15.75µs 🟢 -3.32% 29.76µs 30.10µs ⚪ 0.85% 🟡 91%
execute/
regex_redux
552.46µs 527.50µs 🟢 -4.55% 1.39ms 1.40ms ⚪ 0.24% 🔴 165%
execute/
rev_complement
488.80µs 490.46µs ⚪ 0.41% 1.42ms 1.43ms ⚪ 0.62% 🔴 191%
execute/
tiny_keccak
333.75µs 338.01µs ⚪ 1.11% 1.15ms 1.16ms ⚪ 0.83% 🔴 243%
execute/
trunc_f2i
735.19µs 734.62µs ⚪ -0.08% 2.13ms 2.13ms ⚪ -0.07% 🔴 190%
instantiate/
wasm_kernel
66.09µs 66.34µs ⚪ -0.11% 70.46µs 71.83µs ⚪ -0.27% 🟢 8%
translate/
erc1155
205.40µs 205.20µs ⚪ 0.30% 400.57µs 392.46µs 🟢 -2.36% 🟡 91%
translate/
erc20
101.29µs 101.65µs ⚪ 0.50% 196.69µs 192.18µs 🟢 -2.37% 🟡 89%
translate/
erc721
144.06µs 144.14µs ⚪ -0.48% 285.13µs 279.50µs 🟢 -2.10% 🟡 94%
translate/
spidermonkey
0.00ns 0.00ns 🟢 -1.93% 0.00ns 0.00ns ⚪ 0.13% 🟢 0%
translate/
wasm_kernel
3.82ms 3.68ms 🟢 -4.32% 7.34ms 7.26ms ⚪ -0.85% 🟡 98%

Link to pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants