Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup, refactor and re-organize wasmi_cli crate #655

Merged
merged 34 commits into from
Feb 7, 2023

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Feb 7, 2023

No description provided.

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.39ms 1.39ms ⚪ 0.00% 1.16ms 1.18ms ⚪ 1.29% 🟢 -16%
execute/
bare_call_0/typed
1.01ms 1.02ms ⚪ 0.68% 775.15µs 777.51µs ⚪ 0.38% 🟢 -23%
execute/
bare_call_1
1.43ms 1.43ms 🟢 0.14% 1.35ms 1.39ms 🔴 2.60% 🟢 -3%
execute/
bare_call_16
2.38ms 2.34ms 🟢 -1.12% 4.26ms 4.30ms 🔴 1.09% 🟡 84%
execute/
bare_call_16/typed
1.57ms 1.54ms 🟢 -1.95% 2.23ms 2.48ms 🔴 10.98% 🟡 61%
execute/
bare_call_1/typed
1.11ms 1.11ms ⚪ -0.42% 1.18ms 1.28ms 🔴 8.13% 🟢 15%
execute/
bare_call_4
1.67ms 1.65ms ⚪ -2.16% 1.92ms 1.92ms ⚪ 0.20% 🟢 16%
execute/
bare_call_4/typed
1.12ms 1.11ms ⚪ -0.95% 1.25ms 1.26ms ⚪ 1.16% 🟢 13%
execute/
br_table
1.11ms 1.12ms ⚪ 0.96% 1.39ms 1.40ms ⚪ -0.06% 🟢 24%
execute/
count_until
683.44µs 683.25µs ⚪ -0.05% 2.13ms 2.14ms ⚪ 0.42% 🔴 213%
execute/
factorial_iterative
325.50µs 325.76µs ⚪ 0.03% 927.18µs 906.86µs 🟢 -2.17% 🔴 178%
execute/
factorial_recursive
644.47µs 652.14µs ⚪ 1.13% 1.34ms 1.34ms ⚪ -0.15% 🔴 105%
execute/
fib_iterative
1.36ms 1.36ms ⚪ -0.06% 5.01ms 5.01ms ⚪ -0.24% 🔴 269%
execute/
fib_recursive
5.92ms 6.16ms 🔴 4.12% 12.35ms 11.88ms 🟢 -3.77% 🟡 93%
execute/
global_bump
980.96µs 981.10µs ⚪ 0.00% 2.56ms 2.56ms ⚪ 0.02% 🔴 161%
execute/
global_const
737.89µs 737.74µs ⚪ 0.24% 2.39ms 2.40ms ⚪ 0.05% 🔴 225%
execute/
host_calls
26.49µs 26.21µs ⚪ -0.35% 38.72µs 38.52µs ⚪ -0.51% 🟢 47%
execute/
memory_fill
1.26ms 1.26ms ⚪ -0.04% 4.03ms 4.04ms ⚪ 0.31% 🔴 222%
execute/
memory_sum
1.22ms 1.22ms ⚪ 0.03% 4.01ms 4.00ms ⚪ -0.05% 🔴 229%
execute/
memory_vec_add
2.50ms 2.50ms ⚪ -0.03% 7.65ms 7.63ms ⚪ -0.27% 🔴 205%
execute/
recursive_is_even
1.13ms 1.14ms ⚪ 0.55% 2.27ms 2.25ms ⚪ -0.90% 🟡 98%
execute/
recursive_ok
151.83µs 153.11µs ⚪ 0.78% 305.10µs 306.16µs ⚪ 0.61% 🟡 100%
execute/
recursive_scan
181.57µs 184.84µs 🔴 1.72% 392.67µs 394.02µs ⚪ 0.32% 🔴 113%
execute/
recursive_trap
15.51µs 15.09µs 🟢 -2.78% 30.87µs 31.22µs 🔴 1.21% 🔴 107%
execute/
regex_redux
536.05µs 563.97µs 🔴 5.30% 1.39ms 1.37ms 🟢 -1.49% 🔴 143%
execute/
rev_complement
474.23µs 482.02µs 🔴 1.59% 1.40ms 1.39ms ⚪ -0.12% 🔴 189%
execute/
tiny_keccak
335.59µs 335.79µs ⚪ 0.14% 1.15ms 1.14ms ⚪ 0.36% 🔴 241%
execute/
trunc_f2i
723.04µs 722.64µs ⚪ -0.11% 2.15ms 2.15ms ⚪ 0.02% 🔴 197%
instantiate/
wasm_kernel
65.82µs 64.65µs ⚪ -2.19% 69.40µs 72.39µs 🔴 3.28% 🟢 12%
translate/
erc1155
209.55µs 209.98µs ⚪ -0.02% 388.07µs 396.50µs 🔴 2.18% 🟡 89%
translate/
erc20
103.68µs 104.16µs ⚪ 0.04% 189.91µs 195.58µs 🔴 2.46% 🟡 88%
translate/
erc721
147.70µs 148.63µs ⚪ 0.94% 277.88µs 282.05µs ⚪ 1.38% 🟡 90%
translate/
spidermonkey
0.00ns 0.00ns ⚪ -0.45% 0.00ns 0.00ns 🔴 3.62% 🟢 0%
translate/
wasm_kernel
3.77ms 3.80ms ⚪ 0.50% 7.31ms 7.45ms 🔴 2.18% 🟡 96%

Link to pipeline

@Robbepop Robbepop merged commit 3e6d0d6 into master Feb 7, 2023
@Robbepop Robbepop deleted the rf-cleanup-wasmi-cli branch February 7, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants