Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmi_cli: Display exported funcs for --invoke x when no func named x is exported #678

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

Robbepop
Copy link
Member

No description provided.

@Robbepop Robbepop changed the title wasmi_cli: Display exported funcs for --invoke x when no func is exported under name x wasmi_cli: Display exported funcs for --invoke x when no func named x is exported Feb 14, 2023
@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.48ms 1.46ms 🟢 -1.54% 1.23ms 1.24ms 🔴 0.13% 🟢 -15%
execute/
bare_call_0/typed
1.08ms 1.05ms 🟢 -2.44% 854.00µs 869.48µs 🔴 1.68% 🟢 -17%
execute/
bare_call_1
1.52ms 1.50ms ⚪ -1.30% 1.46ms 1.45ms 🔴 -0.65% 🟢 -3%
execute/
bare_call_16
2.27ms 2.26ms ⚪ -0.70% 4.16ms 4.22ms 🔴 1.53% 🟡 87%
execute/
bare_call_16/typed
1.61ms 1.59ms ⚪ -1.21% 2.38ms 2.41ms ⚪ 1.34% 🟡 52%
execute/
bare_call_1/typed
1.18ms 1.17ms ⚪ -0.82% 1.30ms 1.29ms ⚪ -1.13% 🟢 11%
execute/
bare_call_4
1.64ms 1.63ms ⚪ -1.01% 2.03ms 1.94ms 🟢 -4.63% 🟢 19%
execute/
bare_call_4/typed
1.18ms 1.17ms ⚪ -1.46% 1.37ms 1.39ms ⚪ 1.19% 🟢 19%
execute/
br_table
1.17ms 1.22ms ⚪ 3.35% 1.48ms 1.48ms ⚪ 0.21% 🟢 22%
execute/
count_until
710.81µs 710.79µs ⚪ 0.06% 2.29ms 2.29ms ⚪ -0.02% 🔴 222%
execute/
factorial_iterative
320.26µs 319.31µs ⚪ -0.41% 953.69µs 965.79µs ⚪ 1.11% 🔴 202%
execute/
factorial_recursive
652.03µs 659.35µs 🔴 1.23% 1.31ms 1.42ms 🔴 7.92% 🔴 115%
execute/
fib_iterative
1.42ms 1.42ms ⚪ 0.08% 5.14ms 5.14ms ⚪ -0.02% 🔴 261%
execute/
fib_recursive
6.05ms 5.96ms 🟢 -1.49% 11.60ms 11.76ms 🔴 1.41% 🟡 97%
execute/
global_bump
1.04ms 1.04ms ⚪ -0.12% 2.64ms 2.74ms 🔴 3.85% 🔴 164%
execute/
global_const
711.71µs 715.37µs ⚪ 0.26% 2.41ms 2.44ms ⚪ 0.38% 🔴 241%
execute/
host_calls
28.17µs 28.75µs ⚪ 3.74% 44.68µs 43.39µs 🟢 -2.99% 🟡 51%
execute/
memory_fill
1.31ms 1.31ms ⚪ 0.10% 4.17ms 4.16ms ⚪ -0.23% 🔴 218%
execute/
memory_sum
1.33ms 1.30ms ⚪ -1.96% 4.14ms 4.14ms ⚪ -0.18% 🔴 218%
execute/
memory_vec_add
2.47ms 2.47ms ⚪ 0.18% 7.80ms 7.79ms ⚪ -0.02% 🔴 215%
execute/
recursive_is_even
1.15ms 1.16ms ⚪ 1.41% 2.41ms 2.31ms 🟢 -3.92% 🟡 98%
execute/
recursive_ok
157.56µs 152.72µs 🟢 -3.11% 303.76µs 309.64µs 🔴 2.28% 🔴 103%
execute/
recursive_scan
187.21µs 182.88µs 🟢 -2.39% 369.04µs 385.28µs 🔴 4.69% 🔴 111%
execute/
recursive_trap
15.12µs 15.87µs 🔴 4.96% 31.23µs 31.65µs ⚪ 0.99% 🟡 99%
execute/
regex_redux
541.71µs 535.11µs ⚪ -1.22% 1.39ms 1.39ms ⚪ -0.47% 🔴 159%
execute/
rev_complement
482.40µs 484.65µs ⚪ 0.64% 1.43ms 1.42ms ⚪ -0.44% 🔴 194%
execute/
tiny_keccak
351.32µs 343.97µs ⚪ -1.21% 1.15ms 1.15ms ⚪ 0.05% 🔴 233%
execute/
trunc_f2i
695.38µs 696.46µs ⚪ 0.10% 2.15ms 2.15ms ⚪ 0.00% 🔴 208%
instantiate/
wasm_kernel
63.37µs 63.57µs ⚪ 1.69% 71.22µs 72.07µs ⚪ 1.60% 🟢 13%
translate/
erc1155
234.41µs 235.17µs ⚪ 0.41% 455.71µs 460.57µs ⚪ 0.82% 🟡 96%
translate/
erc20
113.82µs 114.05µs ⚪ 0.42% 218.75µs 221.63µs 🔴 1.37% 🟡 94%
translate/
erc721
162.02µs 161.53µs ⚪ 0.21% 319.76µs 322.12µs ⚪ 0.73% 🟡 99%
translate/
spidermonkey
0.00ns 0.00ns ⚪ 0.32% 0.00ns 0.00ns ⚪ 0.51% 🟢 0%
translate/
wasm_kernel
4.07ms 4.06ms ⚪ -0.40% 8.28ms 8.34ms ⚪ 0.70% 🔴 105%

Link to pipeline

@Robbepop Robbepop merged commit 0a14f20 into master Feb 14, 2023
@Robbepop Robbepop deleted the rf-display-exported-funcs-for-invoke branch February 14, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants