Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization: differentiate function calls #724

Merged
merged 20 commits into from
May 28, 2023
Merged

Optimization: differentiate function calls #724

merged 20 commits into from
May 28, 2023

Commits on May 27, 2023

  1. rename FuncBody -> CompiledFunc

    @Robbepop
    Robbepop committed May 27, 2023
    Configuration menu
    Copy the full SHA
    6beae00 View commit details
    Browse the repository at this point in the history

  2. make CompiledFunc use u32 internally 

    This is to make it possible to use CompiledFunc in wasmi bytecode.
    @Robbepop
    Robbepop committed May 27, 2023
    Configuration menu
    Copy the full SHA
    3c17500 View commit details
    Browse the repository at this point in the history

  3. implement custom Default impl for CodeMap

    @Robbepop
    Robbepop committed May 27, 2023
    Configuration menu
    Copy the full SHA
    d1c0c58 View commit details
    Browse the repository at this point in the history

  4. rename insts -> instrs in CodeMap 

    "insts" is ambiguous in Wasm with "instances" therefore we always want to use "instr" to refer to an instruction.
    @Robbepop
    Robbepop committed May 27, 2023
    Configuration menu
    Copy the full SHA
    7ed724f View commit details
    Browse the repository at this point in the history

  5. refactor InstructionsRef for special 0 value case

    @Robbepop
    Robbepop committed May 27, 2023
    Configuration menu
    Copy the full SHA
    4e36a2c View commit details
    Browse the repository at this point in the history

Commits on May 28, 2023

  1. add FuncHeader::new

    @Robbepop
    Robbepop committed May 28, 2023
    Configuration menu
    Copy the full SHA
    43f25dc View commit details
    Browse the repository at this point in the history

  2. cleanup code slightly

    @Robbepop
    Robbepop committed May 28, 2023
    Configuration menu
    Copy the full SHA
    17ef48e View commit details
    Browse the repository at this point in the history

  3. rename parameter & minor refactoring

    @Robbepop
    Robbepop committed May 28, 2023
    Configuration menu
    Copy the full SHA
    f32e1dc View commit details
    Browse the repository at this point in the history

  4. fix internal doc links with FuncBody -> CompiledFunc

    @Robbepop
    Robbepop committed May 28, 2023
    Configuration menu
    Copy the full SHA
    27282e2 View commit details
    Browse the repository at this point in the history

  5. improve docs in Engine

    @Robbepop
    Robbepop committed May 28, 2023
    Configuration menu
    Copy the full SHA
    e33039d View commit details
    Browse the repository at this point in the history

  6. rename resolve_inst -> resolve_instr

    @Robbepop
    Robbepop committed May 28, 2023
    Configuration menu
    Copy the full SHA
    3ee9112 View commit details
    Browse the repository at this point in the history

  7. add docs to some EngineInner APIs

    @Robbepop
    Robbepop committed May 28, 2023
    Configuration menu
    Copy the full SHA
    0e34f9c View commit details
    Browse the repository at this point in the history

  8. add doc link

    @Robbepop
    Robbepop committed May 28, 2023
    Configuration menu
    Copy the full SHA
    a69cfba View commit details
    Browse the repository at this point in the history

  9. allocate CompiledFunc prior to translation 

    Now instead of allocation CompiledFunc to the `wasmi` Engine as the result of validation and translation of a Wasm function, the CompiledFunc is already allocated and initialized instead.
This allows to access the CompiledFunc index for function calls in other translation units which finally provides the possibility to optimize calls to internal functions.
Also this will make it simpler to run function translations concurrently if we ever decide to want this feature.
    @Robbepop
    Robbepop committed May 28, 2023
    Configuration menu
    Copy the full SHA
    381585f View commit details
    Browse the repository at this point in the history

  10. add new CallInternal instruction

    @Robbepop
    Robbepop committed May 28, 2023
    Configuration menu
    Copy the full SHA
    a8ca866 View commit details
    Browse the repository at this point in the history

  11. remove unnecessary import

    @Robbepop
    Robbepop committed May 28, 2023
    Configuration menu
    Copy the full SHA
    9a952f2 View commit details
    Browse the repository at this point in the history

  12. add docs 

    Maybe we should specialize Call to CallImported and mandate that it is only used for imported functions. This could further optimize the call infrastructure in the engine by relying on this.
    @Robbepop
    Robbepop committed May 28, 2023
    Configuration menu
    Copy the full SHA
    160722e View commit details
    Browse the repository at this point in the history

  13. fix internal doc links

    @Robbepop
    Robbepop committed May 28, 2023
    Configuration menu
    Copy the full SHA
    5612869 View commit details
    Browse the repository at this point in the history

  14. apply rustfmt

    @Robbepop
    Robbepop committed May 28, 2023
    Configuration menu
    Copy the full SHA
    98d3e4c View commit details
    Browse the repository at this point in the history

  15. add ReturnCallInternal instruction

    @Robbepop
    Robbepop committed May 28, 2023
    Configuration menu
    Copy the full SHA
    ef6b5e6 View commit details
    Browse the repository at this point in the history