Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Wasmi CLI arguments and default config #849

Merged
merged 2 commits into from
Dec 17, 2023
Merged

Update Wasmi CLI arguments and default config #849

merged 2 commits into from
Dec 17, 2023

Conversation

Robbepop
Copy link
Member

No description provided.

@Robbepop
Wasmi CLI: enabled Wasm tail-calls and extended-const
b80a4fc 
Those Wasm proposals are not stabilized, yet but we can assume them to be stabilized very soon so enabling them by default is probably a good idea.
@Robbepop
Wasmi CLI: add --lazy to enable lazy compilation
d224573
@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
br_table		 1.47ms 1.53ms 🔴 4.18% 1.27ms 1.31ms 🔴 3.32% 🟢 -14%
execute/
call/host/1		 53.42µs 51.37µs 🟢 -3.84% 64.63µs 68.17µs 🔴 5.47% 🟢 33%
execute/
call/rec		 179.43µs 180.98µs ⚪ 0.86% 368.00µs 365.33µs ⚪ -0.73% 🔴 102%
execute/
count_until		 6.51ms 6.51ms ⚪ 0.04% 7.48ms 7.48ms ⚪ -0.03% 🟢 15%
execute/
divrem		 6.22ms 6.23ms ⚪ 0.08% 7.21ms 7.21ms ⚪ 0.05% 🟢 16%
execute/
factorial/iter		 264.62µs 264.21µs ⚪ -0.15% 333.18µs 333.10µs ⚪ -0.02% 🟢 26%
execute/
factorial/rec		 724.03µs 728.66µs ⚪ 0.64% 1.32ms 1.33ms ⚪ 0.22% 🟡 82%
execute/
fibonacci/iter		 1.36ms 1.36ms ⚪ 0.00% 1.26ms 1.27ms ⚪ 0.02% 🟢 -7%
execute/
fibonacci/rec		 6.59ms 6.68ms 🔴 1.37% 13.20ms 13.86ms 🔴 4.99% 🔴 108%
execute/
fibonacci/tail		 1.45ms 1.45ms ⚪ -0.01% 3.79ms 3.95ms 🔴 4.40% 🔴 173%
execute/
fuse		 7.19ms 7.20ms ⚪ 0.10% 12.18ms 12.19ms ⚪ 0.07% 🟡 69%
execute/
global/bump		 1.32ms 1.32ms ⚪ 0.07% 1.62ms 1.62ms ⚪ -0.02% 🟢 23%
execute/
global/get_const		 693.14µs 694.57µs ⚪ 0.21% 750.45µs 750.97µs ⚪ 0.07% 🟢 8%
execute/
is_even/rec		 1.19ms 1.20ms ⚪ 0.50% 2.33ms 2.35ms ⚪ 0.65% 🟡 97%
execute/
memory/fill_bytes		 1.22ms 1.13ms 🟢 -7.93% 1.35ms 1.34ms ⚪ -0.32% 🟢 19%
execute/
memory/sum_bytes		 1.15ms 1.15ms ⚪ 0.06% 1.32ms 1.32ms ⚪ -0.04% 🟢 14%
execute/
memory/vec_add		 2.97ms 2.95ms ⚪ -0.60% 3.60ms 3.89ms 🔴 7.83% 🟢 32%
execute/
recursive_scan		 200.17µs 201.99µs ⚪ 0.91% 396.25µs 392.97µs ⚪ -0.83% 🟡 95%
execute/
recursive_trap		 17.45µs 17.32µs ⚪ -0.74% 36.55µs 36.03µs 🟢 -1.40% 🔴 108%
execute/
regex_redux		 585.73µs 583.70µs ⚪ -0.35% 1.06ms 1.05ms ⚪ -1.01% 🟡 81%
execute/
rev_complement		 451.64µs 449.48µs ⚪ -0.48% 666.27µs 665.50µs ⚪ -0.12% 🟢 48%
execute/
tiny_keccak		 352.01µs 352.43µs ⚪ 0.12% 383.85µs 383.17µs ⚪ -0.18% 🟢 9%
execute/
trunc_f2i		 634.11µs 615.19µs ⚪ -2.98% 961.82µs 1.01ms 🔴 4.82% 🟡 64%
instantiate/
wasm_kernel		 55.10µs 53.86µs ⚪ -2.26% 57.32µs 53.39µs 🟢 -6.85% 🟢 -1%
overhead/
call/typed/0		 1.26ms 1.28ms ⚪ 1.96% 906.02µs 880.31µs 🟢 -2.84% 🟢 -31%
overhead/
call/typed/16		 1.68ms 1.64ms 🟢 -1.82% 1.94ms 1.94ms ⚪ 0.35% 🟢 18%
overhead/
call/untyped/0		 1.57ms 1.58ms ⚪ 0.29% 1.18ms 1.17ms 🟢 -1.35% 🟢 -26%
overhead/
call/untyped/16		 2.42ms 2.42ms ⚪ -0.36% 3.89ms 3.77ms 🟢 -3.13% 🟡 56%
translate/
bz2/checked/eager/default		 1.32ms 1.33ms ⚪ 0.37% 2.40ms 2.42ms ⚪ 0.66% 🟡 82%
translate/
bz2/checked/eager/fuel		 1.43ms 1.45ms ⚪ 1.00% 2.61ms 2.64ms ⚪ 1.01% 🟡 83%
translate/
bz2/checked/lazy/default		 551.25µs 550.52µs ⚪ -0.13% 963.12µs 965.68µs ⚪ 0.27% 🟡 75%
translate/
bz2/unchecked/eager/default		 1.07ms 1.08ms 🔴 1.18% 1.90ms 1.91ms ⚪ 0.47% 🟡 77%
translate/
bz2/unchecked/eager/fuel		 1.17ms 1.18ms ⚪ 0.58% 2.10ms 2.11ms ⚪ 0.54% 🟡 79%
translate/
bz2/unchecked/lazy/default		 36.46µs 36.12µs ⚪ -0.93% 45.98µs 45.63µs ⚪ -0.74% 🟢 26%
translate/
erc1155/checked/eager/default		 277.72µs 276.34µs ⚪ -0.49% 473.89µs 472.72µs ⚪ -0.25% 🟡 71%
translate/
erc1155/checked/eager/fuel		 298.18µs 295.93µs ⚪ -0.75% 509.45µs 510.91µs ⚪ 0.29% 🟡 73%
translate/
erc1155/checked/lazy/default		 127.87µs 128.75µs ⚪ 0.69% 211.87µs 211.61µs ⚪ -0.12% 🟡 64%
translate/
erc1155/unchecked/eager/default		 227.97µs 228.83µs ⚪ 0.38% 377.37µs 377.65µs ⚪ 0.08% 🟡 65%
translate/
erc1155/unchecked/eager/fuel		 247.08µs 245.13µs ⚪ -0.79% 405.45µs 408.45µs ⚪ 0.74% 🟡 67%
translate/
erc1155/unchecked/lazy/default		 23.76µs 24.64µs 🔴 3.68% 32.88µs 32.26µs ⚪ -1.88% 🟢 31%
translate/
erc20/checked/eager/default		 134.84µs 135.32µs ⚪ 0.35% 228.05µs 226.01µs ⚪ -0.89% 🟡 67%
translate/
erc20/checked/eager/fuel		 142.83µs 142.52µs ⚪ -0.22% 242.69µs 240.69µs ⚪ -0.82% 🟡 69%
translate/
erc20/checked/lazy/default		 65.38µs 66.34µs ⚪ 1.46% 107.04µs 106.81µs ⚪ -0.21% 🟡 61%
translate/
erc20/unchecked/eager/default		 110.24µs 110.53µs ⚪ 0.26% 182.05µs 181.06µs ⚪ -0.54% 🟡 64%
translate/
erc20/unchecked/eager/fuel		 117.51µs 117.51µs ⚪ 0.00% 192.78µs 192.61µs ⚪ -0.09% 🟡 64%
translate/
erc20/unchecked/lazy/default		 18.58µs 18.80µs ⚪ 1.22% 24.69µs 24.41µs ⚪ -1.16% 🟢 30%
translate/
erc721/checked/eager/default		 191.34µs 191.09µs ⚪ -0.13% 329.61µs 327.27µs ⚪ -0.71% 🟡 71%
translate/
erc721/checked/eager/fuel		 200.78µs 201.76µs ⚪ 0.49% 347.34µs 345.95µs ⚪ -0.40% 🟡 71%
translate/
erc721/checked/lazy/default		 90.86µs 91.84µs ⚪ 1.08% 152.36µs 151.98µs ⚪ -0.25% 🟡 65%
translate/
erc721/unchecked/eager/default		 154.46µs 154.23µs ⚪ -0.15% 258.47µs 257.57µs ⚪ -0.35% 🟡 67%
translate/
erc721/unchecked/eager/fuel		 164.08µs 163.24µs ⚪ -0.51% 274.54µs 275.30µs ⚪ 0.28% 🟡 69%
translate/
erc721/unchecked/lazy/default		 21.88µs 21.61µs ⚪ -1.24% 29.60µs 28.23µs 🟢 -4.63% 🟢 31%
translate/
pulldown_cmark/checked/eager/default		 3.65ms 3.66ms ⚪ 0.29% 6.15ms 6.21ms ⚪ 1.08% 🟡 70%
translate/
pulldown_cmark/checked/eager/fuel		 3.94ms 3.94ms ⚪ -0.19% 6.67ms 6.75ms ⚪ 1.23% 🟡 72%
translate/
pulldown_cmark/checked/lazy/default		 1.55ms 1.55ms ⚪ -0.18% 2.58ms 2.57ms ⚪ -0.39% 🟡 66%
translate/
pulldown_cmark/unchecked/eager/default		 3.01ms 3.02ms ⚪ 0.26% 4.95ms 5.00ms ⚪ 1.17% 🟡 66%
translate/
pulldown_cmark/unchecked/eager/fuel		 3.30ms 3.30ms ⚪ 0.12% 5.42ms 5.47ms ⚪ 1.03% 🟡 66%
translate/
pulldown_cmark/unchecked/lazy/default		 246.35µs 244.75µs ⚪ -0.65% 245.56µs 248.56µs ⚪ 1.22% 🟢 2%
translate/
spidermonkey/checked/eager/default		 76.71ms 76.95ms ⚪ 0.31% 133.59ms 134.25ms ⚪ 0.50% 🟡 74%
translate/
spidermonkey/checked/eager/fuel		 82.89ms 83.31ms ⚪ 0.51% 144.45ms 145.36ms ⚪ 0.63% 🟡 74%
translate/
spidermonkey/checked/lazy/default		 33.06ms 33.27ms ⚪ 0.64% 55.97ms 56.20ms ⚪ 0.41% 🟡 69%
translate/
spidermonkey/unchecked/eager/default		 62.75ms 63.15ms ⚪ 0.65% 105.64ms 106.44ms ⚪ 0.76% 🟡 69%
translate/
spidermonkey/unchecked/eager/fuel		 68.94ms 69.30ms ⚪ 0.52% 115.75ms 116.62ms ⚪ 0.74% 🟡 68%
translate/
spidermonkey/unchecked/lazy/default		 3.25ms 3.26ms ⚪ 0.32% 3.74ms 4.00ms 🔴 6.95% 🟢 23%
translate/
wasm_kernel/checked/eager/default		 5.10ms 5.10ms ⚪ -0.03% 8.75ms 8.77ms ⚪ 0.15% 🟡 72%
translate/
wasm_kernel/checked/eager/fuel		 5.25ms 5.26ms ⚪ 0.13% 9.21ms 9.22ms ⚪ 0.15% 🟡 75%
translate/
wasm_kernel/checked/lazy/default		 2.42ms 2.44ms ⚪ 0.90% 4.02ms 4.02ms ⚪ -0.14% 🟡 64%
translate/
wasm_kernel/unchecked/eager/default		 4.05ms 4.10ms ⚪ 1.06% 6.85ms 6.86ms ⚪ 0.24% 🟡 68%
translate/
wasm_kernel/unchecked/eager/fuel		 4.21ms 4.23ms ⚪ 0.28% 7.27ms 7.31ms ⚪ 0.55% 🟡 73%
translate/
wasm_kernel/unchecked/lazy/default		 398.33µs 397.13µs ⚪ -0.30% 462.08µs 466.26µs ⚪ 0.90% 🟢 17%

Link to pipeline

@Robbepop Robbepop merged commit 89b413c into master Dec 17, 2023
20 checks passed
@Robbepop Robbepop deleted the rf-update-wasmi-cli branch December 17, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Robbepop @paritytech-cicd-pr