Merge pull request #598 from wasmx/ci_clang_11

ci: Upgrade build images, Clang to version 11

.clang-tidy

@@ -6,6 +6,7 @@ Checks: >
   google-global-names-in-headers,
   google-runtime-int,
   misc-*,
+  -misc-no-recursion,
   -misc-non-private-member-variables-in-classes,
   performance-*,
   -performance-inefficient-string-concatenation,

circle.yml

@@ -6,15 +6,12 @@ parameters:
     default: false
 
 executors:
-  linux-gcc-9:
-    docker:
-      - image: ethereum/cpp-build-env:15-gcc-9
   linux-gcc-latest:
     docker:
-      - image: ethereum/cpp-build-env:15-gcc-10
+      - image: ethereum/cpp-build-env:16-gcc-10
   linux-clang-latest:
     docker:
-      - image: ethereum/cpp-build-env:15-clang-10
+      - image: ethereum/cpp-build-env:16-clang-11
   macos:
     macos:
       xcode: 11.6.0
@@ -294,7 +291,7 @@ jobs:
       - test
 
   release-linux:
-    executor: linux-gcc-9
+    executor: linux-gcc-latest
     steps:
       - install_testfloat
       - checkout
@@ -392,8 +389,8 @@ jobs:
       - checkout
       - build:
           build_type: RelWithDebInfo
-          # TODO: pointer-compare produces failure in std::string operator+.
-          cmake_options: -DENABLE_ASSERTIONS=ON -DSANITIZE=address,pointer-subtract,undefined,nullability,implicit-unsigned-integer-truncation,implicit-signed-integer-truncation
+          # TODO: Enable pointer-compare and pointer-subtract only for libfizzy.
+          cmake_options: -DENABLE_ASSERTIONS=ON -DSANITIZE=address,undefined,nullability,implicit-unsigned-integer-truncation,implicit-signed-integer-truncation
       - test
       - benchmark:
           min_time: "0.01"

test/utils/fizzy_engine.cpp

@@ -40,7 +40,7 @@ ValType translate_valtype(char input)
 
 FuncType translate_signature(std::string_view signature)
 {
-    const auto delimiter_pos = signature.find(":");
+    const auto delimiter_pos = signature.find(':');
     assert(delimiter_pos != std::string_view::npos);
     const auto inputs = signature.substr(0, delimiter_pos);
     const auto outputs = signature.substr(delimiter_pos + 1);

test/utils/wasm_engine.cpp

@@ -12,9 +12,9 @@ WasmEngine::~WasmEngine() noexcept = default;
 
 void validate_function_signature(std::string_view signature)
 {
-    if (signature.find_first_of(":") == std::string::npos)
+    if (signature.find_first_of(':') == std::string::npos)
         throw std::runtime_error{"Missing ':' delimiter"};
-    if (signature.find_first_of(":") != signature.find_last_of(":"))
+    if (signature.find_first_of(':') != signature.find_last_of(':'))
         throw std::runtime_error{"Multiple occurrences of ':' found in signature"};
     // Only allow i (i32) I (i64) as types
     if (signature.find_first_not_of(":iI") != std::string::npos)