Stack depth counting (and preallocation) #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
reviewed
Feb 26, 2020
| Stack<uint64_t> stack; | ||
| stack.reserve(code.max_stack_depth); |
There was a problem hiding this comment.
To use full potential of this we need custom stack implementation.
axic
commented
Mar 24, 2020
| @@ -408,8 +411,12 @@ parser_result<Code> parse_expr(const uint8_t* pos, const uint8_t* end, bool have | |||
| } | |||
| } | |||
| code.instructions.emplace_back(instr); | |||
| max_stack_depth += instr_stack_change(instr); | |||
There was a problem hiding this comment.
I think we need to move this into/after a validation phase so that we have access to each of the sections (such as types) to know how many stack items are we popping/pushing (for example in call/call_indirect/etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.