-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmarks: add guido-fuzzer-find-1 #234
Conversation
5c44a45
to
8bf8f5f
Compare
@chfast any idea what this means? |
This is effect of To fix it here I would need to refactor our benchmarking code. |
It is not important right now, given this tests a bomb on the parser and execute should trap, so it is not good for the benchmarks I guess. |
2779c04
to
5cf5216
Compare
@chfast could we somehow merge this in a partially-failing way so that we expect wasm3 to fail? |
If you can find a regex pattern to exclude the failing benchmark in |
Current rough numbers:
|
If we disable execution, it could be included. It should help us see if parsing slowed down significantly. |
224b34f
to
dc92096
Compare
Can it be executed now? |
No, that's why I removed the |
That's fine if not executed at all. |
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 62 62
Lines 9048 9048
=======================================
Hits 8889 8889
Misses 159 159 |
Depends on fix from wasm3: wasm3/wasm3#131