Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function section validation #334

Merged
merged 1 commit into from
May 25, 2020
Merged

Fix function section validation #334

merged 1 commit into from
May 25, 2020

Conversation

chfast
Copy link
Collaborator

@chfast chfast commented May 24, 2020

The validation of type indices in function section must be fully
finished before processing any code. This is because there may be a call
in code[i] referencing function[i + n].

@chfast chfast requested review from axic and gumb0 May 24, 2020 13:36
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but how come this isn't fixing a spectest error?

The validation of type indices in function section must be fully
finished before processing any code. This is because there may be a call
in code[i] referencing function[i + n].
@chfast chfast merged commit 89a9694 into master May 25, 2020
@chfast chfast deleted the fix_funcsec_validation branch May 25, 2020 11:16
@chfast chfast added the bug Something isn't working label May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants