validation: use correct function arity in stack height validation #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
changed the title
chfast
reviewed
May 26, 2020
gumb0
force-pushed
the
parse-expr-func-type
branch
from
34df7da
to
604c40e
Compare
chfast
approved these changes
May 26, 2020
axic
reviewed
May 26, 2020
| // TODO: Get function result arity from the function type in Module. | ||
| const uint8_t func_result_arity = 0; | ||
| control_stack.emplace(Instr::block, func_result_arity, 0); // The function's implicit block. | ||
| const auto func_type_idx = module.funcsec[func_idx]; |
There was a problem hiding this comment.
It was like that originally, I changed it just because func_idx seems to be a more natural parameter to "parse instuctions of a function", might be more useful in the future for something.
axic
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for #312
Resolves one TODO in
parse_exprand 45 validation spec tests (must be the tests checking if function stack has enough results at the end of execution)