wasm3: add patch for better start function support #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
approved these changes
May 27, 2020
chfast
approved these changes
May 27, 2020
Codecov Report
@@ Coverage Diff @@
## master #349 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 38 38
Lines 11162 11162
=======================================
Hits 11063 11063
Misses 99 99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes wasm3/wasm3#145 in our patchset.
The main benefit is we don't get hundreds of lines of
Result: <Empty Stack>displayed by fizzy-bench.We have a test case for this,
wasm_engine/start_func, which seems to work.