Raise validation error if referring to unknown global or setting immutable global #351
Conversation
gumb0
force-pushed
the
validate-globals
branch
3 times, most recently
from
d253fcd
to
b1ec2cf
Compare
| @@ -51,6 +51,9 @@ using TableIdx = uint32_t; | |||
| // https://webassembly.github.io/spec/core/syntax/modules.html#syntax-memidx | |||
There was a problem hiding this comment.
BTW these links now go to 1.1 spec
There was a problem hiding this comment.
Do you want to open an issue/PR for us to direct-link to 1.0?
|
Init expressions of globals need to be validated, too, but I would do that in another PR, as it seems a bit more complicated. |
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 98.84% 98.86% +0.01%
==========================================
Files 40 40
Lines 11643 11779 +136
==========================================
+ Hits 11509 11645 +136
Misses 134 134 |
|
@axic This is ready, please review |
Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
| @@ -74,5 +74,13 @@ struct Module | |||
| { | |||
| return !memorysec.empty() || !imported_memory_types.empty(); | |||
| } | |||
|
|
|||
| bool is_global_mutable(GlobalIdx idx) const noexcept | |||
There was a problem hiding this comment.
Hmm, shouldn't we have a unit test for this?
There was a problem hiding this comment.
For the sake of progress I'm merging this, but perhaps we should add unit tests for each module helper in a new PR>
|
Globals validation is poorly covered by spec tests, I added some cases to "to upstream" list |
No description provided.