Raise validation error on invalid start function index #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
reviewed
May 28, 2020
| @@ -781,15 +781,15 @@ TEST(parser, start_invalid_index) | |||
| make_section(3, func_section) + make_section(8, start_section) + | |||
| make_section(10, code_section); | |||
|
|
|||
| EXPECT_THROW_MESSAGE(parse(bin), parser_error, "invalid start function index"); | |||
There was a problem hiding this comment.
these tests should better be moved to validation_test.cpp now
There was a problem hiding this comment.
Hm, I did that quite a few times. Perhaps we should merge these small changes as is and then do a sweep of moving things across?
There was a problem hiding this comment.
Let's coordinate with moving bigger code pieces.
|
Also fixed stat function type checking -- should that be in a new PR or extend this one? |
Codecov Report
@@ Coverage Diff @@
## master #353 +/- ##
=======================================
Coverage 98.84% 98.84%
=======================================
Files 38 38
Lines 11575 11608 +33
=======================================
+ Hits 11441 11474 +33
Misses 134 134 |
gumb0
approved these changes
May 29, 2020
chfast
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.