clang-tidy: Enable readability checks #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
force-pushed
the
clang-tidy-readability
branch
from
1a6e030
to
6877461
Compare
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
=======================================
Coverage 98.93% 98.94%
=======================================
Files 42 42
Lines 12320 12317 -3
=======================================
- Hits 12189 12187 -2
+ Misses 131 130 -1 |
|
@chfast you want to land this? |
chfast
force-pushed
the
clang-tidy-readability
branch
from
6877461
to
c45e12d
Compare
chfast
force-pushed
the
clang-tidy-readability
branch
from
c45e12d
to
461e45a
Compare
gumb0
approved these changes
Jun 8, 2020
axic
reviewed
Jun 8, 2020
| @@ -8,7 +8,7 @@ | |||
| #include <gmock/gmock.h> | |||
| #include <iosfwd> | |||
|
|
|||
| MATCHER(Traps, "") | |||
| MATCHER(Traps, "") // NOLINT(readability-redundant-string-init) | |||
There was a problem hiding this comment.
It generates code like std::string s = "".
axic
reviewed
Jun 8, 2020
| return false; | ||
|
|
||
| return true; | ||
| return r.result == wabt::interp::Result::Ok; |
There was a problem hiding this comment.
I still hoped to prove both branches are covered with #381, but will add back the inverse of this commit for a test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.