Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate constant expressions for data offset initialization #393

Merged
merged 3 commits into from
Jun 26, 2020

Conversation

gumb0
Copy link
Collaborator

@gumb0 gumb0 commented Jun 25, 2020

Second part of #372

@gumb0 gumb0 force-pushed the validate-data-offset-init branch from 107d6f8 to ac8edc5 Compare June 26, 2020 11:00
@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #393 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #393   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          43       43           
  Lines       13009    13027   +18     
=======================================
+ Hits        12900    12918   +18     
  Misses        109      109           

@gumb0 gumb0 force-pushed the validate-data-offset-init branch 2 times, most recently from 78fc047 to eee54ef Compare June 26, 2020 14:22
@gumb0 gumb0 force-pushed the validate-data-offset-init branch from eee54ef to 661d659 Compare June 26, 2020 14:23
@gumb0 gumb0 marked this pull request as ready for review June 26, 2020 14:23
Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So these are not covered by the spectests? If so, can you add this "our list"?

@gumb0
Copy link
Collaborator Author

gumb0 commented Jun 26, 2020

So these are not covered by the spectests? If so, can you add this "our list"?

Yes, I'll add it.

@gumb0 gumb0 merged commit dfdfd51 into master Jun 26, 2020
@gumb0 gumb0 deleted the validate-data-offset-init branch June 26, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants